[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

[GitBox]

apache-mynewt-bot commented on pull request #872:
URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777369628


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### porting/nimble/include/os/queue.h
   <details>
   
   ```diff
   @@ -111,18 +111,18 @@
    /*
     * Singly-linked List declarations.
     */
   -#define     SLIST_HEAD(name, type)                          \
   -struct name {                                           \
   -    struct type *slh_first; /* first element */         \
   -}
   -
   -#define     SLIST_HEAD_INITIALIZER(head)                    \
   +#define SLIST_HEAD(name, type)                          \
   +    struct name {                                           \
   +        struct type *slh_first; /* first element */         \
   +    }
   +
   +#define SLIST_HEAD_INITIALIZER(head)                    \
        { NULL }
    
   -#define     SLIST_ENTRY(type)                               \
   -struct {                                                \
   -    struct type *sle_next;  /* next element */          \
   -}
   +#define SLIST_ENTRY(type)                               \
   +    struct {                                                \
   +        struct type *sle_next; /* next element */          \
   +    }
    
    /*
     * Singly-linked List functions.
   ```
   
   </details>
   
   #### porting/nimble/src/hal_timer.c
   <details>
   
   ```diff
   @@ -75,34 +75,34 @@
    
    static const struct nrf52_hal_timer *nrf52_hal_timers[NRF52_HAL_TIMER_MAX] 
= {
    #if MYNEWT_VAL(TIMER_0)
   -        &nrf52_hal_timer0,
   +    &nrf52_hal_timer0,
    #else
   -        NULL,
   +    NULL,
    #endif
    #if MYNEWT_VAL(TIMER_1)
   -        &nrf52_hal_timer1,
   +    &nrf52_hal_timer1,
    #else
   -        NULL,
   +    NULL,
    #endif
    #if MYNEWT_VAL(TIMER_2)
   -        &nrf52_hal_timer2,
   +    &nrf52_hal_timer2,
    #else
   -        NULL,
   +    NULL,
    #endif
    #if MYNEWT_VAL(TIMER_3)
   -        &nrf52_hal_timer3,
   +    &nrf52_hal_timer3,
    #else
   -        NULL,
   +    NULL,
    #endif
    #if MYNEWT_VAL(TIMER_4)
   -        &nrf52_hal_timer4,
   +    &nrf52_hal_timer4,
    #else
   -        NULL,
   +    NULL,
    #endif
    #if MYNEWT_VAL(TIMER_5)
   -        &nrf52_hal_timer5
   +    &nrf52_hal_timer5
    #else
   -        NULL
   +    NULL
    #endif
    };
    
   @@ -481,51 +481,51 @@
    
        switch (timer_num) {
    #if MYNEWT_VAL(TIMER_0)
   -        case 0:
   +    case 0:
            irq_num = TIMER0_IRQn;
            hwtimer = NRF_TIMER0;
            irq_isr = nrf52_timer0_irq_handler;
            break;
    #endif
    #if MYNEWT_VAL(TIMER_1)
   -        case 1:
   +    case 1:
            irq_num = TIMER1_IRQn;
            hwtimer = NRF_TIMER1;
            irq_isr = nrf52_timer1_irq_handler;
            break;
    #endif
    #if MYNEWT_VAL(TIMER_2)
   -        case 2:
   +    case 2:
            irq_num = TIMER2_IRQn;
            hwtimer = NRF_TIMER2;
            irq_isr = nrf52_timer2_irq_handler;
            break;
    #endif
    #if MYNEWT_VAL(TIMER_3)
   -        case 3:
   +    case 3:
            irq_num = TIMER3_IRQn;
            hwtimer = NRF_TIMER3;
            irq_isr = nrf52_timer3_irq_handler;
            break;
    #endif
    #if MYNEWT_VAL(TIMER_4)
   -        case 4:
   +    case 4:
            irq_num = TIMER4_IRQn;
            hwtimer = NRF_TIMER4;
            irq_isr = nrf52_timer4_irq_handler;
            break;
    #endif
    #if MYNEWT_VAL(TIMER_5)
   -        case 5:
   -            irq_num = RTC0_IRQn;
   -            hwtimer = NRF_RTC0;
   -            irq_isr = nrf52_timer5_irq_handler;
   -            bsptimer->tmr_rtc = 1;
   -            break;
   -#endif
   -        default:
   -            hwtimer = NULL;
   -            break;
   +    case 5:
   +        irq_num = RTC0_IRQn;
   +        hwtimer = NRF_RTC0;
   +        irq_isr = nrf52_timer5_irq_handler;
   +        bsptimer->tmr_rtc = 1;
   +        break;
   +#endif
   +    default:
   +        hwtimer = NULL;
   +        break;
        }
    
        if (hwtimer == NULL) {
   @@ -543,7 +543,7 @@
    
        return 0;
    
   -    err:
   +err:
        return rc;
    }
    
   @@ -675,7 +675,7 @@
    
        return 0;
    
   -    err:
   +err:
        return rc;
    }
    
   @@ -720,7 +720,7 @@
    #endif
        OS_EXIT_CRITICAL(sr);
    
   -    err:
   +err:
        return rc;
    }
    
   @@ -745,7 +745,7 @@
        resolution = 1000000000 / bsptimer->tmr_freq;
        return resolution;
    
   -    err:
   +err:
        rc = 0;
        return rc;
    }
   @@ -776,7 +776,7 @@
        return tcntr;
    
        /* Assert here since there is no invalid return code */
   -    err:
   +err:
        assert(0);
        rc = 0;
        return rc;
   @@ -830,7 +830,7 @@
    
        rc = 0;
    
   -    err:
   +err:
        return rc;
    }
    
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org