This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit ea75882faa98329a92ca16a42e2358ceab901e5f
Author: Magdalena Kasenberg <magdalena.kasenb...@codecoup.pl>
AuthorDate: Wed Feb 24 11:12:07 2021 +0100

    sensors/bma253: Fix identical code
    
    Coverity issue 204156: Identical code for different branches.
---
 hw/drivers/sensors/bma253/src/bma253.c | 30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)

diff --git a/hw/drivers/sensors/bma253/src/bma253.c 
b/hw/drivers/sensors/bma253/src/bma253.c
index e006c62..d9a8c3d 100644
--- a/hw/drivers/sensors/bma253/src/bma253.c
+++ b/hw/drivers/sensors/bma253/src/bma253.c
@@ -777,34 +777,20 @@ quad_to_axis_trigger(struct axis_trigger * axis_trigger,
 }
 
 int
-bma253_get_high_g_int_status(const struct bma253 * bma253,
-                      uint8_t * int_status)
+bma253_get_high_g_int_status(const struct bma253 *bma253,
+                             uint8_t *int_status)
 {
-    int rc = 0;
-
-    rc = get_registers((struct bma253 *)bma253, REG_ADDR_INT_STATUS_3,
-                       int_status, 4);
-    if (rc != 0) {
-        return rc;
-    }
-       return rc;
+    return get_registers((struct bma253 *)bma253, REG_ADDR_INT_STATUS_3,
+                         int_status, 4);
 }
 
 
 int
-bma253_get_int_status(const struct bma253 * bma253,
-                      bma253_int_stat_t * int_status)
+bma253_get_int_status(const struct bma253 *bma253,
+                      bma253_int_stat_t *int_status)
 {
-    int rc;
-
-    rc = get_registers((struct bma253 *)bma253, REG_ADDR_INT_STATUS_0,
-                       (uint8_t*)int_status, 4);
-
-    if (rc != 0) {
-        return rc;
-    }
-
-    return 0;
+    return get_registers((struct bma253 *)bma253, REG_ADDR_INT_STATUS_0,
+                         (uint8_t*)int_status, 4);
 }
 
 int

Reply via email to