andrzej-kaczmarek commented on code in PR #521:
URL: https://github.com/apache/mynewt-newt/pull/521#discussion_r1234534583


##########
newt/syscfg/syscfg.go:
##########
@@ -1599,7 +1599,19 @@ func writePackages(lpkgs []*pkg.LocalPackage, w 
io.Writer) {
        }
 }
 
-func write(cfg Cfg, lpkgs []*pkg.LocalPackage, w io.Writer) {
+func writeApis(apis []string, w io.Writer) {
+       for i, api := range apis {
+               apis[i] = cfgPkgIllegalChar.ReplaceAllLiteralString(api, "_")
+       }
+       sort.Strings(apis)
+
+       fmt.Fprintf(w, "/*** Included APIs */\n")
+       for _, name := range apis {
+               fmt.Fprintf(w, "#define MYNEWT_API_%s 1\n", name)

Review Comment:
   `MYNEWT_API` -> `MYNEWT_PKG_API`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to