rymanluk commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1335498137
########## nimble/host/services/leaudio/include/leaudio/leaudio_common.h: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef LE_AUDIO_COMMON_H_ +#define LE_AUDIO_COMMON_H_ + +#include "stdint.h" + +/** TODO: these lengths may need to be changed to fit more data */ +#define METADATA_MAX_LEN (32) +#define CODEC_SPEC_MAX_LEN (32) + +struct codec_id { + uint8_t format; + uint16_t company_id; + uint16_t vendor_specific; +}__attribute__((packed)); Review Comment: remote packed from public header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
