rahult-github commented on PR #1599: URL: https://github.com/apache/mynewt-nimble/pull/1599#issuecomment-1754963802
> Hi, > > Why not put this configuration in advertising parameters and handle it there? Instead of adding dedicated API that just wraps HCI command Thanks for the review. There is no harm in setting the reasons as part of advertising parameters and issuing this command. But spec says "This command may be used while advertising is enabled". This gives a thought , that this HCI command can be invoked later on also with a reason code as per use case which may not be provided when advertising was enabled? A standalone usage of sending the HCI command is possible. That is why created a separate API. But please let me know if this understanding of mine is incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
