andrzej-kaczmarek commented on code in PR #1714:
URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508720095
##########
nimble/host/audio/syscfg.yml:
##########
@@ -17,5 +17,18 @@
#
syscfg.defs:
+ BLE_MAX_BIG:
Review Comment:
BLE_AUDIO_MAX_BIGS
##########
apps/auracast/syscfg.yml:
##########
@@ -59,4 +59,6 @@ syscfg.vals:
BLE_MAX_BIG: 1
BLE_MAX_BIS: 2
- BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1
\ No newline at end of file
+ BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1
Review Comment:
this is only required on nrf52 if encryption is enabled
##########
apps/btshell/pkg.yml:
##########
@@ -35,6 +35,7 @@ pkg.deps:
- nimble/host/services/gatt
- nimble/host/store/config
- nimble/host/util
+ - nimble/host/audio
Review Comment:
dep should be added by package which defines BLE_AUDIO
##########
nimble/host/syscfg.yml:
##########
@@ -523,6 +514,20 @@ syscfg.defs:
description: 'Minimum level for the BLE EATT log.'
value: 1
+ BLE_MAX_BIG:
Review Comment:
BLE_ISO_MAX_BIGS or BLE_AUDIO_MAX_BIGS
I think the former makes more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
