MariuszSkamra commented on code in PR #1691:
URL: https://github.com/apache/mynewt-nimble/pull/1691#discussion_r1576045949


##########
nimble/host/audio/include/audio/ble_audio.h:
##########
@@ -562,6 +583,66 @@ struct ble_audio_event_codec_unregistered {
     const struct ble_audio_codec_record *record;
 };
 
+/** @brief BASS Source Removed */
+struct ble_audio_event_bass_remote_scan {
+    /** Connection Handle of Broadcast Assistant that is performing Scan 
procedure for us */
+    uint16_t conn_handle;
+};
+
+/** @brief BASS Source Added */
+struct ble_audio_event_bass_source_added {
+    /** Source ID */
+    uint8_t source_id;
+
+    /** Event status. 0 on success, BLE_HS Error code otherwise */
+    uint8_t status;
+};
+
+/** @brief BASS Source Modify */
+struct ble_audio_event_bass_source_modify {
+    /** Source ID */
+    uint8_t source_id;
+
+    /** Event status. 0 on success, BLE_HS Error code otherwise */
+    uint8_t status;
+
+    /** PA Sync operation to be performed by Broadcast Sink */
+    enum {
+        /** Do not synchronise to PA */
+        BLE_AUDIO_EVENT_BASS_NO_SYNC,
+
+        /** Synchronise to PA without using PAST */
+        BLE_AUDIO_EVENT_BASS_SYNC,
+
+        /** Terminate PA Sync */
+        BLE_AUDIO_EVENT_BASS_SYNC_TERMINATE,
+
+        /** Synchronise to PA using PAST */
+        BLE_AUDIO_EVENT_BASS_SYNC_PAST,
+    } pa_sync_operation;
+};
+
+/** @brief BASS Set Broadcast Code */
+struct ble_audio_event_bass_set_broadcast_code {
+    /** Source ID */
+    uint8_t source_id;
+
+    /** Event status. 0 on success, BLE_HS Error code otherwise */
+    uint8_t status;
+
+    /** Source ID */
+    uint8_t broadcast_code[BLE_AUDIO_BROADCAST_CODE_SIZE];
+};

Review Comment:
   Yes, that's what I think of. There is no point of informing app that peer 
performed invalid operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to