mkiiskila commented on a change in pull request #66: image: Add support for
RSA-PSS signatures
URL:
https://github.com/apache/incubator-mynewt-newt/pull/66#discussion_r120978879
##########
File path: newt/image/image.go
##########
@@ -46,6 +46,10 @@ import (
"mynewt.apache.org/newt/util"
)
+// Set this to enable RSA-PSS for RSA signatures, instead of PKCS#1
+// v1.5. Eventually, this should be the default.
+var UseRsaPss = false
Review comment:
This would look better if this setting was a property of Image, as that's
where all the other data associated with the signing process is being collected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
