ccollins476ad commented on a change in pull request #293: apps/btshell: add
bletiny clone that uses new shell
URL:
https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121020741
##########
File path: net/nimble/host/src/ble_gatts.c
##########
@@ -2080,6 +2080,141 @@ ble_gatts_count_cfg(const struct ble_gatt_svc_def
*defs)
return 0;
}
+static const char* ble_gatt_chr_f_names[] = {
Review comment:
The pointed-to strings are const, but the pointers themselves aren't. The
pointers should probably be made const so that this array can be placed in
.text rather than .data.
E.g.,
`static const char * const ble_gatt_chr_f_names[]`
The same comment applies to the ble_gatt_dsc_f_names array below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
