rymanluk commented on a change in pull request #279: BLE Host - Policy for SM
key overflow
URL:
https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r122381160
##########
File path: net/nimble/host/include/host/ble_store.h
##########
@@ -131,6 +137,40 @@ union ble_store_value {
struct ble_store_value_cccd cccd;
};
+struct ble_store_status_event {
+ /**
+ * The type of object that failed to persist; one of the
+ * BLE_STORE_OBJ_TYPE_[...] codes.
+ */
+ int obj_type;
+
+ /**
+ * The type of event being reported; one of the BLE_STORE_EVENT_TYPE_[...]
+ * codes.
+ */
+ int event_code;
+
+ /**
+ * Additional data related to the event; the valid field is inferred from
+ * the obj_type,event_code pair.
+ */
+ union {
+ /**
+ * The record that failed to be written. Valid for the following event
+ * types:
+ * o BLE_STORE_EVENT_OVERFLOW
Review comment:
Ok, please see below what I have in mind.
union {
/**
* The record that failed to be written. Valid for all the obj_type
and following event
* types:
* o BLE_STORE_EVENT_OVERFLOW
*/
const union ble_store_value *value;
/**
* The connection handle of the peer. Valid for the following event
* types:
* o BLE_STORE_EVENT_OVERFLOW_NEXT
*
* and following obj_types:
*
* o BLE_STORE_OBJ_TYPE_OUR_SEC
* o BLE_STORE_OBJ_TYPE_PEER_SEC
*/
uint16_t conn_handle;
};
In this way, whenever we need to handle object which also uses
BLE_STORE_EVENT_OVERFLOW_NEXT but has different data than conn_handle, we can
easly add it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
