[ https://issues.apache.org/jira/browse/NETBEANS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eirik Bakke updated NETBEANS-713: --------------------------------- Description: (Copied from Bugzilla bug [248664|https://netbeans.org/bugzilla/show_bug.cgi?id=248664] ) The editor API defines the JEditorPane client properties [HighlightsLayerExcludes and HighlightsLayerIncludes|http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-editor-lib2/index.html?org/netbeans/spi/editor/highlighting/package-summary.html] to allow clients to show/hide specific highlight layers on demand. The bug is that modifications to these properties are not reflected properly in the editor. The bug seems to be in o.n.modules.editor.lib2.highlighting.HighlightingManager.Highlighting. In the constructor, the paneFilter variable is initialized once from the HighlightsLayerExcludes/HighlightsLayerIncludes client properties, right above where the propertyChangeListener that is supposed to track changes to it is added. The PropertyChangeListener reacts to changes to the client properties by calling rebuildAllLayers(), which calls rebuildAllLayersImpl(), which always just uses the value of paneFilter set in the constructor. Adding this as a JIRA issue to associate with a pull request that I'm about to open. was: (Copied from Bugzilla bug [248664|https://netbeans.org/bugzilla/show_bug.cgi?id=248664]:) The editor API defines the JEditorPane client properties [HighlightsLayerExcludes and HighlightsLayerIncludes|http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-editor-lib2/index.html?org/netbeans/spi/editor/highlighting/package-summary.html] to allow clients to show/hide specific highlight layers on demand. The bug is that modifications to these properties are not reflected properly in the editor. The bug seems to be in o.n.modules.editor.lib2.highlighting.HighlightingManager.Highlighting. In the constructor, the paneFilter variable is initialized once from the HighlightsLayerExcludes/HighlightsLayerIncludes client properties, right above where the propertyChangeListener that is supposed to track changes to it is added. The PropertyChangeListener reacts to changes to the client properties by calling rebuildAllLayers(), which calls rebuildAllLayersImpl(), which always just uses the value of paneFilter set in the constructor. Adding this as a JIRA issue to associate with a pull request that I'm about to open. > HighlightingManager does not track changes to HighlightsLayerExcludes > correctly > ------------------------------------------------------------------------------- > > Key: NETBEANS-713 > URL: https://issues.apache.org/jira/browse/NETBEANS-713 > Project: NetBeans > Issue Type: Bug > Affects Versions: 8.2, 9.0 > Reporter: Eirik Bakke > Priority: Minor > > (Copied from Bugzilla bug > [248664|https://netbeans.org/bugzilla/show_bug.cgi?id=248664] ) > The editor API defines the JEditorPane client properties > [HighlightsLayerExcludes and > HighlightsLayerIncludes|http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-editor-lib2/index.html?org/netbeans/spi/editor/highlighting/package-summary.html] > to allow clients to show/hide specific highlight layers on demand. The bug > is that modifications to these properties are not reflected properly in the > editor. > The bug seems to be in > o.n.modules.editor.lib2.highlighting.HighlightingManager.Highlighting. In the > constructor, the paneFilter variable is initialized once from the > HighlightsLayerExcludes/HighlightsLayerIncludes client properties, right > above where the propertyChangeListener that is supposed to track changes to > it is added. The PropertyChangeListener reacts to changes to the client > properties by calling rebuildAllLayers(), which calls rebuildAllLayersImpl(), > which always just uses the value of paneFilter set in the constructor. > Adding this as a JIRA issue to associate with a pull request that I'm about > to open. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists