[
https://issues.apache.org/jira/browse/NETBEANS-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257680#comment-17257680
]
Lars Bruun-Hansen edited comment on NETBEANS-3094 at 2/26/21, 2:44 PM:
-----------------------------------------------------------------------
I'm re-opening this issue.
This is NBI native binaries so things are little bit different than with the
rest of NetBeans in the sense that a commit to Git doesn't guarantee that the
fix will become part of a release. Native binaries as part of NBI are _not_,
re-build automatically and they will only find their way into an actual release
if a new bundle is uploaded to
[https://netbeans.osuosl.org/binaries/.|https://netbeans.osuosl.org/binaries/]
In this particular case the following needs to happen:
# The new binary, {{cleaner.exe}}, must be build.
# A new ZIP package {{<sha1>-nbi.engine-external-binaries-<version>.zip}} must
be created. This must be based on the current in-use ZIP and then only updating
{{cleaner.exe}} within the ZIP. Then upload new ZIP to
[https://netbeans.osuosl.org/binaries/]. (as of writing the current version of
that ZIP is "11", we would want to bump that to say "12" - the version string
used on these ZIPs has no affinity with the NB versions).
# New PR: Update file {{harness/libs.nbi.engine/external/binaries-list}} to
point to the new ZIP.
Closing this issue should only happen after it has been verified that the fix
has found its way into a release.
was (Author: lbruun):
I'm re-opening this issue.
This is NBI native binaries so things are little bit than with the rest of
NetBeans in the sense that a commit to Git doesn't guarantee that the fix will
become part of a release. Native binaries as part of NBI are _not_, AFAIK,
re-build automatically, unlike all Java code which goes into the IDE.
Closing this issue should only happen after it has been verified that the fix
has found its way into a release.
> NBI Windows Cleaner.exe doesn't delete read-only files
> ------------------------------------------------------
>
> Key: NETBEANS-3094
> URL: https://issues.apache.org/jira/browse/NETBEANS-3094
> Project: NetBeans
> Issue Type: Improvement
> Components: platform - Other
> Affects Versions: 11.1
> Environment: Windows
> Reporter: Lars Bruun-Hansen
> Assignee: Lars Bruun-Hansen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Problem: The Windows Cleaner process isn't able to delete files with
> read-only attribute set.
>
> (Windows Cleaner is a small C application which is part of *NBI* - NetBeans
> Installer)
>
> This is in particular a problem when the uninstaller tries to delete a
> bundled JRE as the JRE has files with read-only attribute set.
> For the record: this has always been a problem. The Unistaller leaves files
> behind and the main reason is this. Note that the equivalent on Linux/Mac,
> the {{cleaner.sh}} script, doesn't suffer from the same problem as it does
> 'rm -f' operation.
> It is rather trivial to fix. I'll file a PR.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
