This is an automated email from the ASF dual-hosted git repository. bwalker pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push: new 4679faa [NETBEANS-5950] - cleanup warnings related to unreachable exception catches (#3126) 4679faa is described below commit 4679faadde45cb11d7ce30f05b9c2832de67adcc Author: Brad Walker <bwal...@musings.com> AuthorDate: Thu Aug 26 07:57:45 2021 -0600 [NETBEANS-5950] - cleanup warnings related to unreachable exception catches (#3126) The java compiler knows explicitly what exceptions are thrown when compiling code. This change removes all the warnings related to "warning: unreachable catch clause" For example: [repeat] /home/bwalker/src/netbeans/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java:297: warning: unreachable catch clause [repeat] } catch(SAXException ex) { [repeat] ^ [repeat] thrown type SAXParseException has already been caught --- .../src/org/netbeans/modules/j2ee/sun/share/plan/Util.java | 2 -- .../org/netbeans/modules/web/refactoring/PositionBoundsResolver.java | 2 -- .../src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java | 5 +---- ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java | 3 --- ide/utilities/src/org/netbeans/modules/url/URLDataObject.java | 3 --- .../modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java | 2 -- .../modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java | 2 -- .../org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java | 3 --- .../netbeans/modules/php/codeception/coverage/CoverageProvider.java | 3 --- 9 files changed, 1 insertion(+), 24 deletions(-) diff --git a/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java b/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java index d9d6ed1..addae36 100644 --- a/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java +++ b/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java @@ -85,8 +85,6 @@ public class Util { dp.addFileEntry(fe); } catch(DDException ex) { giveUp(ex); - } catch (org.netbeans.modules.schema2beans.Schema2BeansException s2bX) { - giveUp(s2bX); } catch (java.beans.PropertyVetoException pv) { giveUp(pv); } diff --git a/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java b/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java index 290b045..07a4ce9 100644 --- a/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java +++ b/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java @@ -155,8 +155,6 @@ public class PositionBoundsResolver { Exceptions.printStackTrace(ex); } catch (FileNotFoundException ex) { Exceptions.printStackTrace(ex); - } catch (IOException ex) { - Exceptions.printStackTrace(ex); } catch (BadLocationException ex) { Exceptions.printStackTrace(ex); } diff --git a/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java b/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java index 01b1003..302ded7 100644 --- a/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java +++ b/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java @@ -291,11 +291,8 @@ public class StrutsConfigDataObject extends MultiDataObject try { Document doc = getDomDocument(is); lastGoodConfig = StrutsConfig.createGraph(doc); - } - catch(SAXParseException ex) { + } catch(SAXParseException ex) { return new SAXParseError(ex); - } catch(SAXException ex) { - throw new IOException(); } return null; } diff --git a/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java b/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java index fbc3164..4163e25 100644 --- a/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java +++ b/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java @@ -289,9 +289,6 @@ final class EventSupport extends SourceEnvironment { resetState(true, false, -1, -1, false); } catch (DataObjectNotFoundException e) { //Ignore - invalidated after fobj.isValid () was called - } catch (IOException ex) { - // should not occur - Exceptions.printStackTrace(ex); } } } diff --git a/ide/utilities/src/org/netbeans/modules/url/URLDataObject.java b/ide/utilities/src/org/netbeans/modules/url/URLDataObject.java index 931db45..622ae7a 100644 --- a/ide/utilities/src/org/netbeans/modules/url/URLDataObject.java +++ b/ide/utilities/src/org/netbeans/modules/url/URLDataObject.java @@ -130,9 +130,6 @@ public class URLDataObject extends MultiDataObject } catch (FileNotFoundException fne) { ErrorManager.getDefault().notify(ErrorManager.WARNING, fne); return null; - } catch (IOException ioe) { - ErrorManager.getDefault().notify(ErrorManager.WARNING, ioe); - return null; } finally { if (is != null) { try { diff --git a/java/j2ee.jpa.refactoring/src/org/netbeans/modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java b/java/j2ee.jpa.refactoring/src/org/netbeans/modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java index c10ad5f..50e7996 100644 --- a/java/j2ee.jpa.refactoring/src/org/netbeans/modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java +++ b/java/j2ee.jpa.refactoring/src/org/netbeans/modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java @@ -156,8 +156,6 @@ public class PositionBoundsResolver { ErrorManager.getDefault().notify(ex); } catch (FileNotFoundException ex) { ErrorManager.getDefault().notify(ex); - } catch (IOException ex) { - ErrorManager.getDefault().notify(ex); } catch (BadLocationException ex) { ErrorManager.getDefault().notify(ex); } diff --git a/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java b/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java index 5dd559e..ef9ffae 100644 --- a/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java +++ b/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java @@ -462,8 +462,6 @@ public class J2SEVolumeCustomizer extends javax.swing.JPanel implements Customiz Exceptions.printStackTrace(mue); } catch (URISyntaxException ue) { Exceptions.printStackTrace(ue); - } catch (IOException ex) { - Exceptions.printStackTrace(ex); } } }//GEN-LAST:event_addResource diff --git a/java/java.platform.ui/src/org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java b/java/java.platform.ui/src/org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java index 9a9f231..47ffd0d 100644 --- a/java/java.platform.ui/src/org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java +++ b/java/java.platform.ui/src/org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java @@ -364,9 +364,6 @@ public class PlatformsCustomizer extends javax.swing.JPanel implements PropertyC } catch (DataObjectNotFoundException dfne) { Exceptions.printStackTrace(dfne); } - catch (IOException ioe) { - Exceptions.printStackTrace(ioe); - } } }); }//GEN-LAST:event_addNewPlatform diff --git a/php/php.codeception/src/org/netbeans/modules/php/codeception/coverage/CoverageProvider.java b/php/php.codeception/src/org/netbeans/modules/php/codeception/coverage/CoverageProvider.java index dabd06e..33538f6 100644 --- a/php/php.codeception/src/org/netbeans/modules/php/codeception/coverage/CoverageProvider.java +++ b/php/php.codeception/src/org/netbeans/modules/php/codeception/coverage/CoverageProvider.java @@ -45,9 +45,6 @@ public class CoverageProvider { LOGGER.info(String.format("File %s not found. If there are no errors in Codeception output (verify in Output window), " + "please report an issue (http://www.netbeans.org/issues/).", Codecept.COVERAGE_LOG)); return null; - } catch (IOException ex) { - LOGGER.log(Level.WARNING, null, ex); - return null; } return coverage; } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists