[
https://issues.apache.org/jira/browse/NETBEANS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248483#comment-16248483
]
ASF GitHub Bot commented on NETBEANS-126:
-----------------------------------------
lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons
URL:
https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343660739
**How they are used:**
* For `css.editor` I don't think the icons add much value. See
[NETBEANS-126](https://issues.apache.org/jira/browse/NETBEANS-126) for how they
are actually used.
* For `"web.browser.api` I'm not aware of how they are actually used.
**The license of the art-work**
I've taken the icons in the PR from the NetBeans Hg. Thus, I assume that
they already have a proper 'free' license. If that assumption falls short then
we'll have to review each and every icon in NetBeans. Ouch!
I wonder if the NetBeans core has (historically) had any policy wrt to icons
and other art work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Browser icons needs to be re-instated
> -------------------------------------
>
> Key: NETBEANS-126
> URL: https://issues.apache.org/jira/browse/NETBEANS-126
> Project: NetBeans
> Issue Type: Bug
> Reporter: lbruun
> Assignee: lbruun
> Priority: Minor
> Labels: donation-fixes, pull-request-available
> Attachments: css-editor-icons-usage.png, css-editor-icons.png,
> nb-icon.png, web-browser-api-icons.png
>
>
> A number of browser icons were "removed" from the donation, in [this
> changeset|http://hg.netbeans.org/releases/rev/034a0c65c347?revcount=1500].
> They weren't actually removed, rather they were all replaced with a dummy
> NetBeans icon. I think Oracle removed them because Oracle couldn't donate
> such icons, as they don't "own" these trademarks.
> h2. Module path "css.editor"
> Removed from {{css.editor}}:
> !css-editor-icons.png!
> The browser icons in this module are - as far as I can tell - only used for
> code completion hints on CSS where they are used to signal if the browser has
> support for the CSS property or not. Example:
> !css-editor-icons-usage.png!
> h2. Module path "web.browser.api"
> Removed from {{web.browser.api}}:
> !web-browser-api-icons.png!
> The above icons are all replaced in the donation with a dummy NetBeans icon:
> !nb-icon.png!
> I'll do a PR to re-instate these.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
