[ 
https://issues.apache.org/jira/browse/NIFI-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655290#comment-14655290
 ] 

ASF GitHub Bot commented on NIFI-774:
-------------------------------------

Github user danbress commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/72#discussion_r36296186
  
    --- Diff: 
nifi/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestDeleteS3Object.java
 ---
    @@ -0,0 +1,70 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.aws.s3;
    +
    +import java.io.IOException;
    +import java.net.URISyntaxException;
    +import java.net.URL;
    +import java.nio.file.Paths;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.nifi.util.TestRunner;
    +import org.apache.nifi.util.TestRunners;
    +import org.junit.Before;
    +import org.junit.Ignore;
    +import org.junit.Test;
    +
    +@Ignore("For local testing only - interacts with S3 so the credentials 
file must be configured and all necessary buckets created")
    +public class TestDeleteS3Object {
    +
    +    private final String CREDENTIALS_FILE = 
System.getProperty("user.home") + "/aws-credentials.properties";
    +
    +    // When you want to test this, you should create a bucket on Amazon S3 
as follows.
    +    private final String TEST_REGION = "us-east-1";
    +    private final String TEST_BUCKET = 
"test-bucket-00000000-0000-0000-0000-1234567890123";
    +
    +    @Before
    --- End diff --
    
    I think what you have in the testSimpleDelete() is mostly there.  I'm 
thinking if you specify a KEY you might be good to go.


> Create a DeleteS3Object Processor
> ---------------------------------
>
>                 Key: NIFI-774
>                 URL: https://issues.apache.org/jira/browse/NIFI-774
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Yu Ishikawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to