[ 
https://issues.apache.org/jira/browse/NIFI-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695637#comment-14695637
 ] 

Bryan Bende edited comment on NIFI-736 at 8/13/15 5:49 PM:
-----------------------------------------------------------

Thanks for reviewing Mark.  I'm onboard with all of these changes and will post 
an updated patch soon. 

The only one I am wondering about is whether or not to append "-service". Is 
there a reason you wouldn't set the base name to "avro" in your example?

If i remember from the processor archetype, I think we wanted the 
artifactBaseName to be the unique part of the top-level artifact. So I guess it 
depends what our convention is for the artifactId of the top level project, if 
it is nifi-artifactBaseName-services or nifi-artifactBaseName-bundle then I 
think you would want artifactBaseName to be "avro" which would give you:

nifi-avro-service
nifi-avro-service-api
nifi-avro-service-api-nar
nifi-avro-service-nar
and a package of org.apache.nifi.avro

I guess the package name still gets screwed up if your base name is anything 
more than one word.



was (Author: bende):
Thanks for reviewing Mark.  I'm onboard with all of these changes and will post 
an updated patch soon. 

The only one I am wondering about is whether or not to append "-service". Is 
there a reason you wouldn't set the base name to "avro" in your example?

If i remember from the processor archetype, I think we wanted the 
artifactBaseName to be the unique part of the top-level artifact. So I guess it 
depends what our convention is for the artifactId of the top level project, if 
it is nifi-{artifactBaseName}-services or nifi-{artifactBaseName}-bundle then I 
think you would want artifactBaseName to be "avro" which would give you:

nifi-avro-service
nifi-avro-service-api
nifi-avro-service-api-nar
nifi-avro-service-nar
and a package of org.apache.nifi.avro

I guess the package name still gets screwed up if your base name is anything 
more than one word.


> Create a Maven Archetype for ControllerServices
> -----------------------------------------------
>
>                 Key: NIFI-736
>                 URL: https://issues.apache.org/jira/browse/NIFI-736
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: NIFI-736.patch
>
>
> It would be helpful for people building extensions to have a good starting 
> point for building controller services, and it would also serve as a good 
> example for learning the dependency relationship between nars.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to