[ 
https://issues.apache.org/jira/browse/NIFI-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974975#comment-14974975
 ] 

Aldrin Piri commented on NIFI-10:
---------------------------------

Looks good in terms of the functional additions.

There was a checkstyle error on ProvenanceReporter, Line 162 for trailing 
whitespace.  InvokeHTTP, TestInvokeHTTP and FlowController all seem to have 
just had their formatting changed without any functional changes.  While I 
agree with the style, these changes might be best done in a separate commit to 
avoid cluttering what is actually changing.

Once checkstyle is fixed up, +1

> Add new Provenance Event types
> ------------------------------
>
>                 Key: NIFI-10
>                 URL: https://issues.apache.org/jira/browse/NIFI-10
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Joseph Witt
>            Assignee: Mark Payne
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: 
> 0001-NIFI-10-Added-FETCH-Provenance-Event-and-updated-pro.patch, 
> 0002-NIFI-10-Added-FETCH-and-DOWNLOAD-Provenance-Events-u.patch
>
>
> Provenance download event should support the notion of proxy chains as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to