[ 
https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004553#comment-15004553
 ] 

ASF GitHub Bot commented on NIFI-748:
-------------------------------------

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/123

    NIFI-748 Fixed logic around handling partial query results from prove…

    …nance repository
    
    - Ensured that failures derived form correlating Document to its actual 
provenance event do fail the entire query and produce partial results with 
warning messages
    - Refactored DocsReader.read() operation.
    - Added test to validate two conditions where the such failures could occur

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-748

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit a4d93c62c88f594ef0cd3739a0536769f1ab9b26
Author: Oleg Zhurakousky <o...@suitcase.io>
Date:   2015-11-13T19:08:39Z

    NIFI-748 Fixed logic around handling partial query results from provenance 
repository
    - Ensured that failures derived form correlating Document to its actual 
provenance event do fail the entire query and produce partial results with 
warning messages
    - Refactored DocsReader.read() operation.
    - Added test to validate two conditions where the such failures could occur

----


> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-748
>                 URL: https://issues.apache.org/jira/browse/NIFI-748
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can 
> be ejected. Disk was accidentally ejected while running. Provenance Event 
> appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so 
> we can't search on that Component ID at all (unless we shrink the time range 
> to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events 
> could not be found and show what we can, rather than erroring out entirely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to