[
https://issues.apache.org/jira/browse/NIFI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005711#comment-15005711
]
ASF GitHub Bot commented on NIFI-1146:
--------------------------------------
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-156770044
Naveen, thanks for contributing this back! Certainly a nice addition to the
GetKafka processor. The patch looks good, but I did have just a couple of small
points of feedback.
For the PropertyDescriptor added, it may helpful to explain in a little
more detail in the "description" what exactly the property controls & when it
takes effect, for those who may be less familiar with Kafka.
I was also a bit confused by the addition of the @WritesAttribute
annotation - it indicates that the outgoing FlowFile will have an attribute
named "auto.offset.reset" but that attribute is not added to the FlowFile. This
may be a misunderstanding of what the @WritesAttribute annotation is used for
perhaps?
Otherwise, the patch looks great. Thanks again for taking the time to
submit the pull request!
> Allow GetKafka to be configured with auto.offset.reset to "largest" or
> "smallest"
> ---------------------------------------------------------------------------------
>
> Key: NIFI-1146
> URL: https://issues.apache.org/jira/browse/NIFI-1146
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Mark Payne
> Labels: beginner, newbie
>
> Currently, the auto.offset.reset value for GetKafka is always set to
> "smallest". This should be made configurable by the user, with the default
> being "smallest" to maintain backward compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
