[ https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005929#comment-15005929 ]
ASF GitHub Bot commented on NIFI-748: ------------------------------------- Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/123#discussion_r44872910 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java --- @@ -47,9 +46,6 @@ public class DocsReader { private final Logger logger = LoggerFactory.getLogger(DocsReader.class); - public DocsReader(final List<File> storageDirectories) { - } - --- End diff -- I'm like 95% with @olegz on this. I believe it is implausible that someone would be calling this method and likely needed a comment that it was public for some other reason than it was a public API. That 5% not with @olegz is adding deprecation tag adds a tiny smidge of tech debt, which would be swept up when we investigate all the deprecated methods for 1.0.0 > If unable to find a specific Provenance event, should not fail entire search > ---------------------------------------------------------------------------- > > Key: NIFI-748 > URL: https://issues.apache.org/jira/browse/NIFI-748 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Reporter: Mark Payne > Assignee: Oleg Zhurakousky > Fix For: 0.4.0 > > > We have a case where running with the prov being written to a disk that can > be ejected. Disk was accidentally ejected while running. Provenance Event > appears to have been indexed but event is not in the repo. > Specifically, we are reaching Line 104 of DocsReader: > {code} > throw new IOException("Failed to find Provenance Event " + d); > {code} > As a result, searching for a specific Component ID is returning an error, so > we can't search on that Component ID at all (unless we shrink the time range > to a time when that didn't occur). > We should generate a warning, and notify the user that X number of events > could not be found and show what we can, rather than erroring out entirely. -- This message was sent by Atlassian JIRA (v6.3.4#6332)