[ 
https://issues.apache.org/jira/browse/NIFI-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091183#comment-15091183
 ] 

Aldrin Piri commented on NIFI-1374:
-----------------------------------

[~joewitt]  Content looks good. There were a few typos and stylistic things I 
think would be handy (including links to the bootstrap properties section).  We 
additionally seemed to have a large number of newlines to end the file.

Those changes are available in a commit at 
https://github.com/apiri/incubator-nifi/commit/d27ea44209c4349568905dce9b337452461f4803

+1 overall on your patch.  If the changes seem appropriate to you, I would be 
happy to merge them in with your original patch and push to the main repository.

> need to better document Java 7 class and codecache limitation in Admin Guide
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-1374
>                 URL: https://issues.apache.org/jira/browse/NIFI-1374
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Matthew Clarke
>            Assignee: Joseph Witt
>            Priority: Minor
>              Labels: beginner, newbie
>             Fix For: 0.5.0
>
>         Attachments: 
> 0001-NIFI-1374-updated-admin-guide-to-provide-advice-for-.patch
>
>
> The documentation provided in NiFi does not include enough information on the 
> default limitations of Java 7 that can offer result in Out of Memory: Permgen 
> conditions.  The Admin Guide should be updated in 2 places:
> 1. under system Requirements we should add a note about using Java 7 and 
> point them to additional guidance under the bootstrap properties section.
> 2, In the bootstrap properties section we should document the commented out 
> java 7 properties in the file and explain why they should have they should be 
> used when running with Java 7.
> Further, the codecache issues present in Java 7 and Java 8 also warrant 
> commentary as the results can be terrible and extremely hard to figure out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to