[
https://issues.apache.org/jira/browse/NIFI-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167614#comment-15167614
]
ASF GitHub Bot commented on NIFI-1511:
--------------------------------------
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/220#issuecomment-188922521
Ran the tests, verified the Groovy JAR was available to the scripting NAR
and that the Groovy unit tests ran successfully.
LGTM, needs +1/merge from committer
> Incorporate Groovy unit tests as part of the build instead of via profile
> -------------------------------------------------------------------------
>
> Key: NIFI-1511
> URL: https://issues.apache.org/jira/browse/NIFI-1511
> Project: Apache NiFi
> Issue Type: Task
> Components: Tools and Build
> Affects Versions: 0.5.0
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
>
> From the mailing list:
> {quote}
> Recommend *not* running the groovy tests. They set the groovy
> dependency to test scope which means groovy ends up not supported in
> the convenience binary.
> # Verify the build works including release audit tool (RAT) checks
> cd nifi-0.5.0
> mvn clean install -Pcontrib-check
> We should work to get the groovy stuff into the build without needing
> profile activation if they should be the norm.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
