[ https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173954#comment-15173954 ]
ASF GitHub Bot commented on NIFI-1464: -------------------------------------- Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r54588819 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/ProcessorNode.java --- @@ -99,4 +108,96 @@ public ProcessorNode(final Processor processor, final String id, */ public abstract void verifyCanStart(Set<ControllerServiceNode> ignoredReferences); + /** + * + */ + @Override + public ScheduledState getScheduledState() { + return this.scheduledState.get(); + } + + /** + * Returns the logical state of this processor. Logical state ignores + * transition states such as STOPPING and STARTING rounding it up to the + * next logical state of STOPPED and RUNNING respectively. + * + * @return the logical state of this processor [DISABLED, STOPPED, RUNNING] + */ + public ScheduledState getLogicalScheduledState() { --- End diff -- Good. I like this approach. > Refactor lifecycle code for Processors and other components > ----------------------------------------------------------- > > Key: NIFI-1464 > URL: https://issues.apache.org/jira/browse/NIFI-1464 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Oleg Zhurakousky > Assignee: Oleg Zhurakousky > Fix For: 0.6.0 > > > Similar lifecycle handling improvements that went in as part of the NIFI-1164 > for ControllerServices, could/should be applied to other components (e..g, > Processors). > The improvements may also help to address NIFI-78 (may be without killing the > thread). -- This message was sent by Atlassian JIRA (v6.3.4#6332)