[ 
https://issues.apache.org/jira/browse/NIFI-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192587#comment-15192587
 ] 

ASF GitHub Bot commented on NIFI-1620:
--------------------------------------

Github user joewitt commented on the pull request:

    https://github.com/apache/nifi/pull/272#issuecomment-196089886
  
    i was reviewing this earlier today and frankly had a similar concern to 
this as Adam.  I didn't reply because I hadn't really figured out what to 
think.  First, I agree that a service which rejects that header is arguably 
broken.  Second, as the patch is right now I am curious how it works when the 
value is empty string because there is a static call to MediaType.... which 
seems like it would have trouble (still need to verify the logic there though).
    
    However, having said this Pierre can you clarify if the intent is only for 
the case where there is no entity body or is it also for when there is an 
entity body in the request?  If the idea is that this is only necessary when 
there is no entity body we should tighten the code for that case and if it is 
for either scenario then I think i'm of similar mind to Adam here.


> Allow empty Content-Type in InvokeHTTP processor
> ------------------------------------------------
>
>                 Key: NIFI-1620
>                 URL: https://issues.apache.org/jira/browse/NIFI-1620
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 0.5.1
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>             Fix For: 0.6.0
>
>
> External API could expect a POST request without a Content-Type property or 
> at least with this property empty:
> *Error example:*
> {quote}
> You provided a non-empty HTTP "Content-Type" header ("application/json").  
> This API function requires that the header be missing or empty.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to