[
https://issues.apache.org/jira/browse/NIFI-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203550#comment-15203550
]
ASF GitHub Bot commented on NIFI-1656:
--------------------------------------
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/292
NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale …
…problems in unit tests
See:
https://issues.apache.org/jira/browse/NIFI-1656
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #292
----
commit 56832747d365ca87ecc51660e3d9637d9dee825f
Author: trkurc <[email protected]>
Date: 2016-03-20T22:25:04Z
NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale
problems in unit tests
----
> Kite processor scanner usage presumes a particular locale
> ---------------------------------------------------------
>
> Key: NIFI-1656
> URL: https://issues.apache.org/jira/browse/NIFI-1656
> Project: Apache NiFi
> Issue Type: Bug
> Environment: Windows 7 pro, maven 3.3.9, Java 8
> Reporter: Pierre Villard
> Assignee: Tony Kurc
>
> This is a JIRA which spawned from the discussion/review efforts folks did on
> NIFI-1651.
> Sorry for the delay... I am on a different computer than usual and forgot to
> check the git property. Did a full clone again (so slow with airport wifi...)
> and checked the schema (looks OK to me). The git property solved most of the
> issues, but some are remaining:
> Running org.apache.nifi.processors.kite.TestAvroRecordConverter
> Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.377 sec <<<
> FAILURE! - in org.apache.nifi.processors.kite.TestAvroRecordConverter
> testDefaultConversion(org.apache.nifi.processors.kite.TestAvroRecordConverter)
> Time elapsed: 0.011 sec <<< ERROR!
> org.apache.nifi.processors.kite.AvroRecordConverter$AvroConversionException:
> Cannot convert 5.5 to double
> at
> org.apache.nifi.processors.kite.AvroRecordConverter.convertData(AvroRecordConverter.java:246)
> at
> org.apache.nifi.processors.kite.AvroRecordConverter.convert(AvroRecordConverter.java:170)
> at
> org.apache.nifi.processors.kite.TestAvroRecordConverter.testDefaultConversion(TestAvroRecordConverter.java:98)
> Running org.apache.nifi.processors.kite.TestConfigurationProperty
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.849 sec -
> in org.apache.nifi.processors.kite.TestConfigurationProperty
> Running org.apache.nifi.processors.kite.TestConvertAvroSchema
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec <<<
> FAILURE! - in org.apache.nifi.processors.kite.TestConvertAvroSchema
> testBasicConversion(org.apache.nifi.processors.kite.TestConvertAvroSchema)
> Time elapsed: 0.21 sec <<< FAILURE!
> java.lang.AssertionError: Should convert 2 rows expected:<2> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at
> org.apache.nifi.processors.kite.TestConvertAvroSchema.testBasicConversion(TestConvertAvroSchema.java:78)
> Just for the record, the error is because of my local env. This is fixed by
> setting the locale to US on the scanner:
> scanner.useLocale(java.util.Locale.US);
> I don't know if there is a way to set this at a global scale.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
