[ 
https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231882#comment-15231882
 ] 

ASF GitHub Bot commented on NIFI-1180:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/336

    NIFI-1180 Adding more IT tests.

    I've checkout the latest master, built and played with it, it works without 
any issue!
    The Integration Tests worked fine with my AWS environment.
    By doing that, I thought it'd be helpful to add more IT test to illustrate 
how ServerSideEncryption works.
    
    The idea is using PutS3Object and FetchS3Object consecutively then assert 
FlowFile's attribute is set or empty based on the specified SSE algorithm.
    
    Also I've added ITFetchS3Object to check if the downloaded content matches 
with expected one.
    
    Would you review the test case? I hope it'll make IT a little bit more 
robust.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi NIFI-1180

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #336
    
----
commit 0e0f9c846a6bc9845ba6f8ba84b844d5bf2b9fe6
Author: ijokarumawak <ijokaruma...@gmail.com>
Date:   2016-04-08T08:20:27Z

    NIFI-1180 Adding more IT tests.

----


> Modify PutS3Object to enable encryption
> ---------------------------------------
>
>                 Key: NIFI-1180
>                 URL: https://issues.apache.org/jira/browse/NIFI-1180
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Elli Schwarz
>            Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the 
> PutS3Object class, the objectMetadata object contains a method 
> setSSEAlgorithm which can set encryption for the objects. A Nifi property 
> should be added to the PutS3Object class so a user can enable/disable 
> encryption from the processor itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to