[ 
https://issues.apache.org/jira/browse/MINIFI-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233373#comment-15233373
 ] 

ASF GitHub Bot commented on MINIFI-2:
-------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59110888
  
    --- Diff: 
minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeListener.java
 ---
    @@ -0,0 +1,30 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +/**
    + * Interface for handling events detected and driven by an associated 
{@link ConfigurationChangeNotifier} to which the listener
    + * has registered via {@link 
ConfigurationChangeNotifier#registerListener(ConfigurationChangeListener)}.
    + */
    +public interface ConfigurationChangeListener {
    +
    +    /**
    +     * Provides a mechanism for the implementation to interpret the 
specified
    +     */
    +    void handleChange();
    --- End diff --
    
    Fair point on this one.  I was thinking a bit narrowly on the file case, 
but providing an InputStream to the consumer (in this case bootstrap) should 
provide some nice flexibility on both sides of the process.


> File based implementation
> -------------------------
>
>                 Key: MINIFI-2
>                 URL: https://issues.apache.org/jira/browse/MINIFI-2
>             Project: Apache NiFi MiNiFi
>          Issue Type: Sub-task
>          Components: Processing Configuration
>            Reporter: Aldrin Piri
>             Fix For: 0.0.1
>
>         Attachments: ConfigFileExplanation.xml, Properties_Guide.md, 
> config.yml
>
>
> A defined schema for processing configuration will need to be defined.  XML 
> or YAML seem like possible options for achieving this.
> Agent configuration will come from two places, a bootstrap properties file 
> and a flow configuration file. The bootstrap will make use of some of the 
> original nifi.properties in order to start up the agent. The flow 
> configuration file will essentially be a stripped down version of a flow.xml 
> (with potentially S2S properties from nifi.properties).
> The format for the bootstrap.properties should likely be similar to 
> nifi.properties. 
> Further, a way to incorporate this to leverage the libraries from core NiFi 
> will aid in achieving a proof of concept implementation more expediently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to