[ https://issues.apache.org/jira/browse/NIFI-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244486#comment-15244486 ]
ASF subversion and git services commented on NIFI-1685: ------------------------------------------------------- Commit 678d64d1d4a05122182b0d57901bda685e0506dc in nifi's branch refs/heads/master from [~Toivo Adams] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=678d64d ] NIFI-1685 Optimize database Junit tests to reduce execution time. Removed commented blocks. This closes #304. Signed-off-by: Joe Skora <jsk...@apache.org> > Optimize database Junit tests to reduce execution time. > ------------------------------------------------------- > > Key: NIFI-1685 > URL: https://issues.apache.org/jira/browse/NIFI-1685 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build > Reporter: Toivo Adams > Assignee: Toivo Adams > Priority: Minor > Labels: build, test > > Some database Junit tests are slow. > For example: > Running org.apache.nifi.processors.standard.TestPutSQL > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.638 sec > - in org.apache.nifi.processors.standard.TestPutSQL > Running org.apache.nifi.processors.standard.util.TestJdbcCommon > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.029 sec - > in org.apache.nifi.processors.standard.util.TestJdbcCommon > Running org.apache.nifi.processors.standard.TestExecuteSQL > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.978 sec - > in org.apache.nifi.processors.standard.TestExecuteSQL > Running org.apache.nifi.processors.standard.util.TestJdbcHugeStream > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.253 sec - > in org.apache.nifi.processors.standard.util.TestJdbcHugeStream > Running org.apache.nifi.processors.standard.QueryDatabaseTableTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.544 sec - > in org.apache.nifi.processors.standard.QueryDatabaseTableTest > My dev machine is not the fastest one, but still why waste time. > One of reasons is creating DBCPService for each test. > Setting up Connection pooling is expensive operation. > So DBCPService should be set up only once and reuse in each test. > Thanks > Toivo -- This message was sent by Atlassian JIRA (v6.3.4#6332)