[ https://issues.apache.org/jira/browse/NIFI-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254368#comment-15254368 ]
ASF GitHub Bot commented on NIFI-1678: -------------------------------------- Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60781310 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message/AdaptedNodeConnectionStatus.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.cluster.protocol.jaxb.message; + +import org.apache.nifi.cluster.coordination.node.DisconnectionCode; +import org.apache.nifi.cluster.coordination.node.NodeConnectionState; + +public class AdaptedNodeConnectionStatus { + private NodeConnectionState state; + private DisconnectionCode disconnectCode; + private String disconnectReason; + private Long connectionRequestTime; + + public AdaptedNodeConnectionStatus() { + } --- End diff -- Nope. Removing. > Nodes in cluster should use ZooKeeper to store heartbeat messages instead of > sending to NCM > ------------------------------------------------------------------------------------------- > > Key: NIFI-1678 > URL: https://issues.apache.org/jira/browse/NIFI-1678 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Reporter: Mark Payne > Assignee: Mark Payne > Fix For: 1.0.0 > > > Currently, nodes send heartbeats to the NCM periodically in order to indicate > that they are actively participating in the cluster. As we move away from > using an NCM, we need these heartbeats to go somewhere else. ZooKeeper is a > reasonable location to push the heartbeats to, as it provides the HA that we > need -- This message was sent by Atlassian JIRA (v6.3.4#6332)