[ 
https://issues.apache.org/jira/browse/NIFI-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272473#comment-15272473
 ] 

Oleg Zhurakousky commented on NIFI-1774:
----------------------------------------

Just to clarify a bit more, the reason why OnConfigured is deprecated is 
because its name doesn't really corresponds to its intent which is _invoke this 
method every time configuration property is changed_. This means that it will 
be invoked as many times as property changes detected. The @OnEnable annotation 
on the other hand is invoked once per service life-cycle. So, changing 
OnConfigured to OnPropertyChange or something alike sounds more appropriate. 
Once available we can then re-annotate 
AbstractControllerService#onConfigurationChange(..) operation. 
Creation of new annotation could be done as part of this JIRA or new one. For 
purity sake I would suggest creation of a 'Task' ticket to create new 
annotation and link to this one although I understand how it could be 
considered an over-kill.

P.S. my apology for pulling a trigger on this one

> AbstractControllerService: use of deprecated Annotation
> -------------------------------------------------------
>
>                 Key: NIFI-1774
>                 URL: https://issues.apache.org/jira/browse/NIFI-1774
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Brandon DeVries
>            Priority: Trivial
>
> AbstractControllerService is using the deprecated annotation \@OnConfigured.  
> Possibly should be org.apache.nifi.annotation.lifecycle.OnEnabled.
> https://github.com/apache/nifi/blob/e4b7e47836edf47042973e604005058c28eed23b/nifi-api/src/main/java/org/apache/nifi/controller/AbstractControllerService.java#L52



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to