[ 
https://issues.apache.org/jira/browse/NIFI-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311473#comment-15311473
 ] 

ASF GitHub Bot commented on NIFI-1118:
--------------------------------------

Github user markobean commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/444#discussion_r65467161
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
 ---
    @@ -94,12 +118,16 @@
                 
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
                 .defaultValue("0")
                 .build();
    +    public static final PropertyDescriptor HEADER_MARKER = new 
PropertyDescriptor.Builder()
    +            .name("Header Line Marker Characters")
    +            .description("The first character(s) on the line of the 
datafile which signifies a header line. This value is ignored when Header Line 
Count is non-zero. " +
    +                    "The first line not containing the Header Line Marker 
Characters and all subsequent lines are considered non-header")
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
         public static final PropertyDescriptor REMOVE_TRAILING_NEWLINES = new 
PropertyDescriptor.Builder()
                 .name("Remove Trailing Newlines")
    -            .description("Whether to remove newlines at the end of each 
split file. This should be false if you intend to merge the split files later. 
If this is set to "
    -                + "'true' and a FlowFile is generated that contains only 
'empty lines' (i.e., consists only of \r and \n characters), the FlowFile will 
not be emitted. "
    -                + "Note, however, that if the Header Line Count is greater 
than 0, the resultant FlowFile will never be empty as it will consist of the 
header lines, so "
    -                + "a FlowFile may be emitted that contians only the header 
lines.")
    +            .description("Whether to remove newlines at the end of each 
split file. This should be false if you intend to merge the split files later.")
    --- End diff --
    
    @mosermw, agreed. Original description put back in place (with spelling 
correction)


> Enable SplitText processor to limit line length and filter header lines
> -----------------------------------------------------------------------
>
>                 Key: NIFI-1118
>                 URL: https://issues.apache.org/jira/browse/NIFI-1118
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Bean
>            Assignee: Mark Bean
>             Fix For: 0.7.0
>
>
> Include the following functionality to the SplitText processor:
> 1) Maximum size limit of the split file(s)
> A new split file will be created if the next line to be added to the current 
> split file exceeds a user-defined maximum file size
> 2) Header line marker
> User-defined character(s) can be used to identify the header line(s) of the 
> data file rather than a predetermined number of lines
> These changes are additions, not a replacement of any property or behavior. 
> In the case of header line marker, the existing property "Header Line Count" 
> must be zero for the new property and behavior to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to