[ 
https://issues.apache.org/jira/browse/NIFI-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332323#comment-15332323
 ] 

ASF GitHub Bot commented on NIFI-1850:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/511#discussion_r67223433
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-jolt-transform-json-ui/src/main/java/org/apache/nifi/web/util/CustomUIUtils.java
 ---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.web.util;
    +
    +import javax.servlet.http.HttpServletRequest;
    +import javax.ws.rs.core.CacheControl;
    +import javax.ws.rs.core.Response;
    +
    +import org.apache.nifi.web.ComponentDetails;
    +import org.apache.nifi.web.HttpServletConfigurationRequestContext;
    +import org.apache.nifi.web.HttpServletRequestContext;
    +import org.apache.nifi.web.NiFiWebConfigurationContext;
    +import org.apache.nifi.web.NiFiWebConfigurationRequestContext;
    +import org.apache.nifi.web.NiFiWebRequestContext;
    +import org.apache.nifi.web.Revision;
    +import org.apache.nifi.web.UiExtensionType;
    +
    +
    +public class CustomUIUtils {
    --- End diff --
    
    Well, I don't really care where it lives at this point. What I was trying 
to emphasize is the "rule of thumb" where everything must be _private_ *until* 
you have justification to make it _public_. This makes our life much simpler 
since we can introduce changes freely in the future. But when its public we 
have to account for backward compatibility. Also we can always make something 
public out of private, but we can never go the other way. So whenever I see new 
class and it's public the red light in my head goes off.


> JSON-to-JSON Schema Converter Editor
> ------------------------------------
>
>                 Key: NIFI-1850
>                 URL: https://issues.apache.org/jira/browse/NIFI-1850
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Core UI
>            Reporter: Yolanda M. Davis
>            Assignee: Yolanda M. Davis
>            Priority: Minor
>             Fix For: 0.7.0
>
>
> With NIFI-361 implemented, users can embed a JOLT spec into the TransformJSON 
> processor. However, building the spec is not intuitive enough without the 
> ability to obtain real time feedback on spec syntax and preview output data. 
> Would like to have a specification editor and transform  preview view added 
> to the processor configuration screen to  allow users to immediately see the 
> impact on the output JSON data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to