[ https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334677#comment-15334677 ]
ASF GitHub Bot commented on NIFI-1838: -------------------------------------- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67423663 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile) { throw new FlowFileHandlingException(flowFile + " is not the most recent version of this flow file within this session"); } + for (final List<MockFlowFile> flowFiles : transferMap.values()) { if (flowFiles.contains(flowFile)) { throw new IllegalStateException(flowFile + " has already been transferred"); } } } + private void validateDestinationRelation(final Relationship relationship) { + if (!relationships.contains(relationship)) { + rollback(); --- End diff -- This class is limited to testing purpose, so throwing an exception would make fail the associated test. I think this is what we want and in this case rollback is not needed. In a real context we should not be in such situation where the relationship does not exist. > Groovy Test Scripts will require refactoring if we implement NIFI-1152 > ---------------------------------------------------------------------- > > Key: NIFI-1838 > URL: https://issues.apache.org/jira/browse/NIFI-1838 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Affects Versions: 1.0.0, 0.6.1 > Reporter: Puspendu Banerjee > Labels: patch > Fix For: 1.0.0 > > Attachments: > 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch > > > Groovy Test Scripts will require refractoring we implement NIFI-1152 as they > don't define Relationships properly -- This message was sent by Atlassian JIRA (v6.3.4#6332)