[
https://issues.apache.org/jira/browse/NIFI-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335153#comment-15335153
]
ASF subversion and git services commented on NIFI-1731:
-------------------------------------------------------
Commit 937b01344edfdfc654d7397820c37e55301c26d4 in nifi's branch refs/heads/0.x
from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=937b013 ]
NIFI-1690 Changed MonitorMemory to use allowable values for pool names
- removed dead code from MonitorMemory
- added MonitorMemoryTest
- minor refactoring in MonitorMemory
- initial fix for NIFI-1731 (WARN/INFO logging) that was required by
MonitorMemoryTest
NIFI-1690 polishing
NIFI-1690 address PR comments, removed default value for MEMORY_POOL_PROPERTY
NIFI-1690 addressed latest PR comments
NIFI-1690 fixed breaking changes
NIFI-1690 0.x port (+1 squashed commit)
Squashed commits:
[1051c8b] Fixed checkstyle issue.
This closes #533.
Signed-off-by: Andy LoPresto <[email protected]>
> CapturingLogger mishandles formatted messages
> ---------------------------------------------
>
> Key: NIFI-1731
> URL: https://issues.apache.org/jira/browse/NIFI-1731
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Priority: Minor
>
> Here is the example of such mishandling
> {code}
> public void warn(String format, Object arg) {
> warnMessages.add(new LogMessage(null, format, null, arg));
> logger.warn(format, arg);
> }
> {code}
> where it really has to be
> {code}
> public void warn(String format, Object arg) {
> Object[] args = new Object[] { arg };
> warnMessages.add(new LogMessage(null,
> MessageFormatter.arrayFormat(format, args).getMessage(), null, args));
> logger.warn(format, arg);
> }
> {code}
> Basically instead of _message_ we are currently passing _format_ into the
> 'message' field of LogMessage constructor which results in something like
> "{}" being the value of the message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
