[ 
https://issues.apache.org/jira/browse/NIFI-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336718#comment-15336718
 ] 

ASF GitHub Bot commented on NIFI-1578:
--------------------------------------

Github user adamonduty commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/256#discussion_r67559978
  
    --- Diff: 
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
 ---
    @@ -0,0 +1,245 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.slack;
    +
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.stream.io.DataOutputStream;
    +
    +import javax.json.Json;
    +import javax.json.JsonObject;
    +import javax.json.JsonObjectBuilder;
    +import javax.json.JsonWriter;
    +import java.io.IOException;
    +import java.io.StringWriter;
    +import java.net.HttpURLConnection;
    +import java.net.URL;
    +import java.net.URLEncoder;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +@Tags({"put", "slack", "notify"})
    +@CapabilityDescription("Sends a message to your team on slack.com")
    +@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
    +public class PutSlack extends AbstractProcessor {
    +
    +    public static final PropertyDescriptor WEBHOOK_URL = new 
PropertyDescriptor
    +            .Builder()
    +            .name("webhook-url")
    +            .displayName("Webhook URL")
    +            .description("The POST URL provided by Slack to send messages 
into a channel.")
    +            .required(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .addValidator(StandardValidators.URL_VALIDATOR)
    +            .sensitive(true)
    +            .build();
    +
    +    public static final PropertyDescriptor WEBHOOK_TEXT = new 
PropertyDescriptor
    +            .Builder()
    +            .name("webhook-text")
    +            .displayName("Webhook Text")
    +            .description("The text sent in the webhook message")
    +            .required(true)
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor CHANNEL = new PropertyDescriptor
    +            .Builder()
    +            .name("channel")
    +            .displayName("Channel")
    +            .description("A public channel using #channel or direct 
message using @username. If not specified, " +
    +                    "the default webhook channel as specified in Slack's 
Incoming Webhooks web interface is used.")
    +            .required(false)
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor USERNAME = new 
PropertyDescriptor
    +            .Builder()
    +            .name("username")
    +            .displayName("Username")
    +            .description("The displayed Slack username")
    +            .required(false)
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor ICON_URL = new 
PropertyDescriptor
    +            .Builder()
    +            .name("icon-url")
    +            .displayName("Icon URL")
    +            .description("Icon URL to be used for the message")
    --- End diff --
    
    Yeah, I noticed some similar funny behavior on Slack's side as well with 
respect to the icon url and icon emoji, but I'm worried that if we document it 
within the processor, Slack will change the behavior and those docs will be out 
of date. I'm also not sure we can anticipate all those idiosyncrasies with 
their API, so I guess defeatism has set in from my perspective.
    
    Plus, it sounds like your experience is different than mine. Slack seems to 
cache the icon url/emoji on a per-username basis. If I change the username, I 
can get different icons/emojis, otherwise they stay the same.
    
    <img width="239" alt="screenshot 2016-06-16 22 12 20" 
src="https://cloud.githubusercontent.com/assets/98686/16140615/ac6135dc-340f-11e6-9d04-51db5a64bb53.png";>



> Create PutSlack processor
> -------------------------
>
>                 Key: NIFI-1578
>                 URL: https://issues.apache.org/jira/browse/NIFI-1578
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Adam Lamar
>            Assignee: Adam Lamar
>             Fix For: 1.0.0, 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to