[
https://issues.apache.org/jira/browse/MINIFI-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357403#comment-15357403
]
ASF GitHub Bot commented on MINIFI-41:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69165759
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17 @@
* limitations under the License.
*/
-package org.apache.nifi.minifi.bootstrap.util.schema.common;
+package org.apache.nifi.minifi.commons.schema;
import java.lang.reflect.Constructor;
import java.lang.reflect.InvocationTargetException;
+import java.util.Collections;
+import java.util.LinkedHashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
public class BaseSchema {
--- End diff --
I think I originally should have made this class Abstract. One of the main
things is the toMap method. In this class all it does it return a LinkedHashMap
and that just feels off to me. I see that others are overriding it and just
using this to get a LinkedHashMap. Also I think it is counter intuitive to have
the ability to initialize a BaseSchema.
Overall I believe all the "Value Access/Interpretation helper methods"
should be make static and toMap would be abstract. Thoughts?
> Command Line Configuration Utility
> ----------------------------------
>
> Key: MINIFI-41
> URL: https://issues.apache.org/jira/browse/MINIFI-41
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Reporter: Bryan Rosander
>
> It would really increase usability if we had a way to transform template xmls
> into configuration YAML files for consumption by MiNiFi.
> The utility should:
> 1. Transform template xmls exported from NiFi into configuration YAML files.
> 2. Validate the contents of a given YAML file in the same way MiNiFi does at
> runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
