[
https://issues.apache.org/jira/browse/MINIFI-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511409#comment-15511409
]
ASF GitHub Bot commented on MINIFI-105:
---------------------------------------
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/36
MINIFI-105 Fixing BootstrapCodec tertiary command order of operations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit c4a855b5d6a88e82131165c991b88ad9b7663023
Author: Joseph Percivall <joeperciv...@yahoo.com>
Date: 2016-09-21T22:30:43Z
MINIFI-105 Fixing BootstrapCodec tertiary command order of operations
----
> BootstrapCodec can throw exceptions with unintended message
> -----------------------------------------------------------
>
> Key: MINIFI-105
> URL: https://issues.apache.org/jira/browse/MINIFI-105
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Jeff Storck
> Priority: Minor
> Fix For: 0.1.0
>
>
> In BootstrapCodec.java, when the following tertiary expression gets
> evaluated, it never will be null, due to the string concatination. This
> causes the IOException message to always be "Details: " with the
> InvalidCommandException's toString result.
> {code}
> try {
> processRequest(cmd, args);
> } catch (final InvalidCommandException ice) {
> throw new IOException("Received invalid command from NiFi: " + line + " :
> " + ice.getMessage() == null ? "" : "Details: " + ice.toString());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
