[ 
https://issues.apache.org/jira/browse/MINIFI-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878594#comment-15878594
 ] 

ASF GitHub Bot commented on MINIFI-222:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102499834
  
    --- Diff: include/spdlog/sinks/msvc_sink.h ---
    @@ -0,0 +1,50 @@
    +//
    +// Copyright(c) 2016 Alexander Dalshov.
    --- End diff --
    
    Also should be covered in LICENSE


> upgrade spdlog
> --------------
>
>                 Key: MINIFI-222
>                 URL: https://issues.apache.org/jira/browse/MINIFI-222
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Minor
>             Fix For: cpp-0.2.0
>
>
> Upgrade and test more recent version of spdlog



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to