[ 
https://issues.apache.org/jira/browse/MINIFI-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940525#comment-15940525
 ] 

ASF GitHub Bot commented on MINIFI-225:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107926105
  
    --- Diff: thirdparty/google-styleguide/cppguide.html ---
    @@ -0,0 +1,6170 @@
    +<!DOCTYPE html>
    --- End diff --
    
    Should likely just link to this in docs some place.  As best as I can tell, 
this file is CC-By 3.0 as per 
https://github.com/google/styleguide/blob/gh-pages/README.md.  This falls under 
a Category B (http://www.apache.org/legal/resolved.html#category-b) which seems 
to have some caveats best avoided unless there is a compelling reason to 
include 


> Include cpplinter and apply google code style formatter
> -------------------------------------------------------
>
>                 Key: MINIFI-225
>                 URL: https://issues.apache.org/jira/browse/MINIFI-225
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Trivial
>             Fix For: cpp-0.2.0
>
>
> Apply the google C++ linter to identify issues and correct as needed. This 
> will come in a series of commits. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to