[ https://issues.apache.org/jira/browse/MINIFI-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993903#comment-15993903 ]
ASF GitHub Bot commented on MINIFI-286: --------------------------------------- GitHub user jdye64 opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/88 MINIFI-286: Fix compilcation error when GCC version is greater than 4.9 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdye64/nifi-minifi-cpp MINIFI-286 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 ---- commit 7c6c85179d5a4acf60bd7a2b95b6d9173da62d29 Author: jdye64 <jdy...@gmail.com> Date: 2017-05-02T22:25:42Z MINIFI-286: Fix compilcation error when GCC version is greater than 4.9 ---- > GetFile filter fails to compile with GCC version greater than 4.9 > ----------------------------------------------------------------- > > Key: MINIFI-286 > URL: https://issues.apache.org/jira/browse/MINIFI-286 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ > Reporter: Jeremy Dyer > Assignee: Jeremy Dyer > Fix For: cpp-0.2.0 > > > GetFile.cpp has a macro which if the GCC version is greater than 4.9 a line > of code is introduced where "fileFilter" is used rather than > "request.fileFilter" which causes a compilation error. > GCC Version = 4.9.2 > /opt/nifi-minifi-cpp/libminifi/src/processors/GetFile.cpp: In member function > ‘bool org::apache::nifi::minifi::processors::GetFile::acceptFile(std::string, > std::string, const org::apache::nifi::minifi::processors::GetFileRequest&)’: > /opt/nifi-minifi-cpp/libminifi/src/processors/GetFile.cpp:283:21: error: > ‘fileFilter’ was not declared in this scope > std::regex re(fileFilter); -- This message was sent by Atlassian JIRA (v6.3.15#6346)