[ 
https://issues.apache.org/jira/browse/MINIFI-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023127#comment-16023127
 ] 

ASF GitHub Bot commented on MINIFI-207:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/102


> findProcessor in ProcessGroup not thread safe
> ---------------------------------------------
>
>                 Key: MINIFI-207
>                 URL: https://issues.apache.org/jira/browse/MINIFI-207
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: cpp-0.1.0
>            Reporter: marco polo
>            Assignee: marco polo
>             Fix For: cpp-0.3.0
>
>
> These functions do not use the mutex. the sets can be change the underlying 
> tree upon insertion. Since flow cannot be guaranteed we should use the mutex 
> here ( i.e. it can be called in any order since it is public ). 
> add and remove connection call this function and lock the mutex themselves. 
> An alternative might be to use a recursive mutex or dramatically reduce the 
> critical section in add/remove connection. This appears more desirable. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to