[ https://issues.apache.org/jira/browse/MINIFI-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060869#comment-16060869 ]
ASF GitHub Bot commented on MINIFI-324: --------------------------------------- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123644079 --- Diff: libminifi/include/provenance/Provenance.h --- @@ -160,21 +161,9 @@ class ProvenanceEventRecord : protected org::apache::nifi::minifi::io::Serializa /*! * Create a new provenance event record */ - ProvenanceEventRecord(ProvenanceEventType event, std::string componentId, std::string componentType) - : logger_(logging::LoggerFactory<ProvenanceEventRecord>::getLogger()) { - _eventType = event; - _componentId = componentId; - _componentType = componentType; - _eventTime = getTimeMillis(); - char eventIdStr[37]; - // Generate the global UUID for th event - uuid_generate(_eventId); - uuid_unparse_lower(_eventId, eventIdStr); - _eventIdStr = eventIdStr; - } + ProvenanceEventRecord(ProvenanceEventType event, std::string componentId, std::string componentType); --- End diff -- Thanks. I'm guilty of doing this too and it's so much cleaner to move it out. > Explore alternative ways to supply identifiers > ---------------------------------------------- > > Key: MINIFI-324 > URL: https://issues.apache.org/jira/browse/MINIFI-324 > Project: Apache NiFi MiNiFi > Issue Type: Improvement > Reporter: marco polo > Assignee: Bryan Rosander > Priority: Minor > > As [~bryanrosan...@gmail.com] mentioned, we could either increment a value in > place of generating unique identifiers for any non NiFi related comms ( i.e. > internal objects, claims, etc ) > Generating unique identifiers is costly and this may not be a cost all > consumers wish to incur. -- This message was sent by Atlassian JIRA (v6.4.14#64029)