[nifi-minifi-cpp] 04/05: Review update

[lordgamez]

This is an automated email from the ASF dual-hosted git repository.

lordgamez pushed a commit to branch MINIFICPP-2152
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git

commit c3dd67df605d8ab24b028d9a4cc77e78ef9d4986
Author: Gabor Gyimesi <gamezb...@gmail.com>
AuthorDate: Tue Aug 8 13:01:47 2023 +0200

    Review update
---
 extensions/http-curl/client/HTTPClient.cpp    | 4 ++--
 extensions/http-curl/client/HTTPClient.h      | 2 +-
 libminifi/include/utils/net/AsioSocketUtils.h | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/extensions/http-curl/client/HTTPClient.cpp 
b/extensions/http-curl/client/HTTPClient.cpp
index f375dc772..4282e4dc2 100644
--- a/extensions/http-curl/client/HTTPClient.cpp
+++ b/extensions/http-curl/client/HTTPClient.cpp
@@ -44,8 +44,8 @@ HTTPClient::HTTPClient(std::string url, 
std::shared_ptr<minifi::controllers::SSL
   http_session_.reset(curl_easy_init());
 }
 
-HTTPClient::HTTPClient(std::string name, const utils::Identifier& uuid)
-    : core::Connectable(std::move(name), uuid) {
+HTTPClient::HTTPClient(std::string_view name, const utils::Identifier& uuid)
+    : core::Connectable(name, uuid) {
   http_session_.reset(curl_easy_init());
 }
 
diff --git a/extensions/http-curl/client/HTTPClient.h 
b/extensions/http-curl/client/HTTPClient.h
index 30c10f486..2e98bab67 100644
--- a/extensions/http-curl/client/HTTPClient.h
+++ b/extensions/http-curl/client/HTTPClient.h
@@ -68,7 +68,7 @@ class HTTPClient : public utils::BaseHTTPClient, public 
core::Connectable {
  public:
   HTTPClient();
 
-  HTTPClient(std::string name, const utils::Identifier& uuid);
+  HTTPClient(std::string_view name, const utils::Identifier& uuid);
 
   HTTPClient(const HTTPClient&) = delete;
   HTTPClient& operator=(const HTTPClient&) = delete;
diff --git a/libminifi/include/utils/net/AsioSocketUtils.h 
b/libminifi/include/utils/net/AsioSocketUtils.h
index 032e73236..20f632f85 100644
--- a/libminifi/include/utils/net/AsioSocketUtils.h
+++ b/libminifi/include/utils/net/AsioSocketUtils.h
@@ -79,9 +79,9 @@ class AsioSocketConnection : public io::BaseStream {
     gsl_Expects(stream_);
     return stream_->read(out_buffer);
   }
-  size_t write(const uint8_t *value, size_t len) override {
+  size_t write(const uint8_t *in_buffer, size_t len) override {
     gsl_Expects(stream_);
-    return stream_->write(value, len);
+    return stream_->write(in_buffer, len);
   }
 
   void setInterface(const std::string& local_network_interface) {