This is an automated email from the ASF dual-hosted git repository. martinzink pushed a commit to branch controller_c_api_requirements in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
commit 14a56e57ed40b823c17de622bb6540a6333eeda8 Author: Adam Debreceni <[email protected]> AuthorDate: Thu Mar 12 09:03:06 2026 +0100 MINIFICPP-2715 - Windows fix, format --- libminifi/src/core/extension/ApiVersion.cpp | 2 +- .../test/integration/extension-verification-test/CApiExtension.cpp | 2 +- .../test/integration/extension-verification-test/CMakeLists.txt | 6 +++--- .../integration/extension-verification-test/CreateNotCalled.cpp | 2 +- .../extension-verification-test/ExtensionVerificationTests.cpp | 4 ++-- .../extension-verification-test/InvalidMissingInitExtension.cpp | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libminifi/src/core/extension/ApiVersion.cpp b/libminifi/src/core/extension/ApiVersion.cpp index 15f59d18b..bf5259420 100644 --- a/libminifi/src/core/extension/ApiVersion.cpp +++ b/libminifi/src/core/extension/ApiVersion.cpp @@ -39,4 +39,4 @@ void test_setMinSupportedApiVersion(uint32_t min_api_version) { min_supported_api_version = min_api_version; } -} // namespace org::apache::nifi::minifi::core::extension \ No newline at end of file +} // namespace org::apache::nifi::minifi::core::extension diff --git a/libminifi/test/integration/extension-verification-test/CApiExtension.cpp b/libminifi/test/integration/extension-verification-test/CApiExtension.cpp index bbd51809a..c93f1c1f2 100644 --- a/libminifi/test/integration/extension-verification-test/CApiExtension.cpp +++ b/libminifi/test/integration/extension-verification-test/CApiExtension.cpp @@ -36,4 +36,4 @@ extern "C" void MinifiInitExtension(MinifiExtension* extension, MinifiConfig* /* .processors_ptr = nullptr, }; MinifiCreateExtension(extension, &ext_create_info); -} \ No newline at end of file +} diff --git a/libminifi/test/integration/extension-verification-test/CMakeLists.txt b/libminifi/test/integration/extension-verification-test/CMakeLists.txt index fa428b044..378b9c64e 100644 --- a/libminifi/test/integration/extension-verification-test/CMakeLists.txt +++ b/libminifi/test/integration/extension-verification-test/CMakeLists.txt @@ -51,12 +51,12 @@ target_include_directories(dummy-core-minifi INTERFACE $<TARGET_PROPERTY:minifi- if (WIN32) set(DUMMY_IMPORT_LIB_FILE ${CMAKE_CURRENT_BINARY_DIR}/dummy-cpp-api.lib) add_custom_target(dummy_cpp_api_import_lib - COMMAND lib.exe /def:${CMAKE_CURRENT_SOURCE_DIR}/dummy-cpp-api.def /out:${IMPORT_LIB_FILE} /machine:x64 - BYPRODUCTS ${IMPORT_LIB_FILE} + COMMAND lib.exe /def:${CMAKE_CURRENT_SOURCE_DIR}/dummy-cpp-api.def /out:${DUMMY_IMPORT_LIB_FILE} /machine:x64 + BYPRODUCTS ${DUMMY_IMPORT_LIB_FILE} ) add_dependencies(dummy-core-minifi dummy_cpp_api_import_lib) - target_link_libraries(dummy-core-minifi INTERFACE ${IMPORT_LIB_FILE}) + target_link_libraries(dummy-core-minifi INTERFACE ${DUMMY_IMPORT_LIB_FILE}) elseif (APPLE) target_link_options(dummy-core-minifi INTERFACE -undefined dynamic_lookup) endif() diff --git a/libminifi/test/integration/extension-verification-test/CreateNotCalled.cpp b/libminifi/test/integration/extension-verification-test/CreateNotCalled.cpp index ec6e5394d..1ae88ebf8 100644 --- a/libminifi/test/integration/extension-verification-test/CreateNotCalled.cpp +++ b/libminifi/test/integration/extension-verification-test/CreateNotCalled.cpp @@ -22,4 +22,4 @@ extern "C" const uint32_t MinifiApiVersion = MINIFI_TEST_API_VERSION; extern "C" void MinifiInitExtension(MinifiExtension* extension, MinifiConfig* /*config*/) { // NOT CALLING CREATE -} \ No newline at end of file +} diff --git a/libminifi/test/integration/extension-verification-test/ExtensionVerificationTests.cpp b/libminifi/test/integration/extension-verification-test/ExtensionVerificationTests.cpp index a31700bf7..c0bec8b8c 100644 --- a/libminifi/test/integration/extension-verification-test/ExtensionVerificationTests.cpp +++ b/libminifi/test/integration/extension-verification-test/ExtensionVerificationTests.cpp @@ -28,7 +28,7 @@ namespace minifi = org::apache::nifi::minifi; class ExtensionLoadingTestController { public: - ExtensionLoadingTestController(std::string pattern): extension_manager_{[&] () { + explicit ExtensionLoadingTestController(std::string pattern): extension_manager_{[&] () { LogTestController::getInstance().clear(); LogTestController::getInstance().setTrace<core::extension::ExtensionManager>(); LogTestController::getInstance().setTrace<core::extension::Extension>(); @@ -39,7 +39,7 @@ class ExtensionLoadingTestController { return config; }()} {} - core::extension::ExtensionManager extension_manager_; + core::extension::ExtensionManager extension_manager_; }; TEST_CASE("Can load cpp-api extensions with same build id") { diff --git a/libminifi/test/integration/extension-verification-test/InvalidMissingInitExtension.cpp b/libminifi/test/integration/extension-verification-test/InvalidMissingInitExtension.cpp index 3fbb5023e..55b2539b7 100644 --- a/libminifi/test/integration/extension-verification-test/InvalidMissingInitExtension.cpp +++ b/libminifi/test/integration/extension-verification-test/InvalidMissingInitExtension.cpp @@ -14,4 +14,4 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. - */ \ No newline at end of file + */
