(nifi) branch main updated: NIFI-16437 - Connector configuration API rejects unset asset references returned by GET (#11777)

[pvillard]

This is an automated email from the ASF dual-hosted git repository.

pvillard31 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git


The following commit(s) were added to refs/heads/main by this push:
     new f026154de3f NIFI-16437 - Connector configuration API rejects unset 
asset references returned by GET (#11777)
f026154de3f is described below

commit f026154de3f666ba5dd77140a41ead1926e76a1d
Author: Pierre Villard <pierre.villard...@gmail.com>
AuthorDate: Wed Oct 7 14:40:58 2026 +0200

    NIFI-16437 - Connector configuration API rejects unset asset references 
returned by GET (#11777)
---
 .../authorization/AuthorizeConnectorConfigReferences.java    |  2 +-
 .../AuthorizeConnectorConfigReferencesTest.java              | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferences.java
 
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferences.java
index 9927c5355cc..709d2e48984 100644
--- 
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferences.java
+++ 
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferences.java
@@ -108,7 +108,7 @@ public final class AuthorizeConnectorConfigReferences {
             final NiFiUser user
     ) {
         if (assetReferences == null || assetReferences.isEmpty()) {
-            throw new IllegalArgumentException("Asset references must be 
specified when value type is ASSET_REFERENCE");
+            return;
         }
 
         for (final AssetReferenceDTO assetReference : assetReferences) {
diff --git 
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferencesTest.java
 
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferencesTest.java
index 3a4b762c017..d66b8508f9d 100644
--- 
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferencesTest.java
+++ 
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/authorization/AuthorizeConnectorConfigReferencesTest.java
@@ -154,30 +154,30 @@ class AuthorizeConnectorConfigReferencesTest {
     }
 
     @Test
-    void testRejectsNullAssetReferences() {
+    void testAllowsNullAssetReferences() {
         
when(lookup.getConnector(eq(CONNECTOR_ID))).thenReturn(connectorAuthorizable);
 
         final ConnectorValueReferenceDTO valueReference = new 
ConnectorValueReferenceDTO();
         
valueReference.setValueType(ConnectorValueType.ASSET_REFERENCE.toString());
         valueReference.setAssetReferences(null);
 
-        assertThrows(IllegalArgumentException.class,
-                () -> AuthorizeConnectorConfigReferences.authorize(authorizer, 
lookup, CONNECTOR_ID, configurationStepWithValue(valueReference)));
+        AuthorizeConnectorConfigReferences.authorize(authorizer, lookup, 
CONNECTOR_ID, configurationStepWithValue(valueReference));
 
+        verify(connectorAuthorizable).authorize(eq(authorizer), 
eq(RequestAction.WRITE), any());
         verify(lookup, never()).getConnectorAsset(any(), any());
     }
 
     @Test
-    void testRejectsEmptyAssetReferences() {
+    void testAllowsEmptyAssetReferences() {
         
when(lookup.getConnector(eq(CONNECTOR_ID))).thenReturn(connectorAuthorizable);
 
         final ConnectorValueReferenceDTO valueReference = new 
ConnectorValueReferenceDTO();
         
valueReference.setValueType(ConnectorValueType.ASSET_REFERENCE.toString());
         valueReference.setAssetReferences(List.of());
 
-        assertThrows(IllegalArgumentException.class,
-                () -> AuthorizeConnectorConfigReferences.authorize(authorizer, 
lookup, CONNECTOR_ID, configurationStepWithValue(valueReference)));
+        AuthorizeConnectorConfigReferences.authorize(authorizer, lookup, 
CONNECTOR_ID, configurationStepWithValue(valueReference));
 
+        verify(connectorAuthorizable).authorize(eq(authorizer), 
eq(RequestAction.WRITE), any());
         verify(lookup, never()).getConnectorAsset(any(), any());
     }