This is an automated email from the ASF dual-hosted git repository.
exceptionfactory pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/main by this push:
new eeed7d3fdf3 NIFI-16492 Replaced size() checks with isEmpty() (#11835)
eeed7d3fdf3 is described below
commit eeed7d3fdf32613959c511f8bd016f0932dc793f
Author: dan-s1 <[email protected]>
AuthorDate: Thu Oct 22 16:39:39 2026 -0400
NIFI-16492 Replaced size() checks with isEmpty() (#11835)
Signed-off-by: David Handermann <[email protected]>
---
.../language/evaluation/functions/JsonPathBaseEvaluator.java | 2 +-
.../language/evaluation/functions/SubstringAfterEvaluator.java | 2 +-
.../evaluation/functions/SubstringBeforeEvaluator.java | 2 +-
.../main/java/org/apache/nifi/metrics/jvm/JmxJvmMetrics.java | 2 +-
.../java/org/apache/nifi/remote/client/SiteToSiteClient.java | 2 +-
.../apache/nifi/flowfile/attributes/FragmentAttributes.java | 2 +-
.../src/main/java/org/apache/nifi/util/StringSelector.java | 2 +-
.../java/org/apache/nifi/util/text/RegexDateTimeMatcher.java | 4 ++--
.../nifi/atlassian/bitbucket/BitbucketRepositoryClient.java | 2 +-
.../apache/nifi/azure/devops/AzureDevOpsRepositoryClient.java | 4 ++--
.../apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java | 2 +-
.../nifi/processors/elasticsearch/PutElasticsearchJson.java | 4 ++--
.../apache/nifi/processors/hadoop/AbstractHadoopProcessor.java | 4 ++--
.../main/java/org/apache/nifi/json/JsonSchemaInference.java | 2 +-
.../org/apache/nifi/processors/groovyx/util/Throwables.java | 2 +-
.../main/java/org/apache/nifi/processors/hadoop/GetHDFS.java | 2 +-
.../main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java | 2 +-
.../org/apache/nifi/processors/media/ExtractMediaMetadata.java | 2 +-
.../src/main/java/org/apache/nifi/grok/GrokReader.java | 2 +-
.../src/main/java/org/apache/nifi/grok/GrokRecordReader.java | 2 +-
.../src/main/java/org/apache/nifi/xml/XMLRecordReader.java | 2 +-
.../java/org/apache/nifi/processors/zendesk/GetZendesk.java | 2 +-
.../single/user/SingleUserLoginIdentityProvider.java | 2 +-
.../org/apache/nifi/web/api/dto/RemoteProcessGroupDTO.java | 10 +++++-----
.../nifi/controller/repository/StandardProcessSession.java | 2 +-
.../java/org/apache/nifi/properties/NiFiPropertiesLoader.java | 2 +-
.../java/org/apache/nifi/remote/StandardRemoteGroupPort.java | 4 ++--
.../nifi/web/dao/impl/StandardRemoteProcessGroupDAO.java | 6 +++---
.../src/main/java/org/apache/nifi/util/MockProcessSession.java | 2 +-
.../registry/hook/WhitelistFilteringEventHookProvider.java | 2 +-
.../system/registry/ExternalControllerServiceVersioningIT.java | 2 +-
.../org/apache/nifi/tests/system/registry/RebaseVersionIT.java | 4 ++--
32 files changed, 44 insertions(+), 44 deletions(-)
diff --git
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathBaseEvaluator.java
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathBaseEvaluator.java
index 283aa3805a8..98342f2c768 100644
---
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathBaseEvaluator.java
+++
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathBaseEvaluator.java
@@ -64,7 +64,7 @@ public abstract class JsonPathBaseEvaluator extends
StringEvaluator {
protected DocumentContext getDocumentContext(EvaluationContext context) {
final String subjectValue = subject.evaluate(context).getValue();
- if (subjectValue == null || subjectValue.length() == 0) {
+ if (subjectValue == null || subjectValue.isEmpty()) {
throw new AttributeExpressionLanguageException("Subject is empty");
}
DocumentContext documentContext = null;
diff --git
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringAfterEvaluator.java
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringAfterEvaluator.java
index f4f24c08256..5613349cc3e 100644
---
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringAfterEvaluator.java
+++
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringAfterEvaluator.java
@@ -39,7 +39,7 @@ public class SubstringAfterEvaluator extends StringEvaluator {
return new StringQueryResult("");
}
final String afterValue =
afterEvaluator.evaluate(evaluationContext).getValue();
- if (afterValue == null || afterValue.length() == 0) {
+ if (afterValue == null || afterValue.isEmpty()) {
return new StringQueryResult(subjectValue);
}
diff --git
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringBeforeEvaluator.java
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringBeforeEvaluator.java
index 2b69bc396e5..37bc67673c1 100644
---
a/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringBeforeEvaluator.java
+++
b/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/SubstringBeforeEvaluator.java
@@ -39,7 +39,7 @@ public class SubstringBeforeEvaluator extends StringEvaluator
{
return new StringQueryResult("");
}
final String beforeValue =
beforeEvaluator.evaluate(evaluationContext).getValue();
- if (beforeValue == null || beforeValue.length() == 0) {
+ if (beforeValue == null || beforeValue.isEmpty()) {
return new StringQueryResult(subjectValue);
}
final int index = subjectValue.indexOf(beforeValue);
diff --git
a/nifi-commons/nifi-metrics/src/main/java/org/apache/nifi/metrics/jvm/JmxJvmMetrics.java
b/nifi-commons/nifi-metrics/src/main/java/org/apache/nifi/metrics/jvm/JmxJvmMetrics.java
index 130aea44e8d..71c0cacdee1 100644
---
a/nifi-commons/nifi-metrics/src/main/java/org/apache/nifi/metrics/jvm/JmxJvmMetrics.java
+++
b/nifi-commons/nifi-metrics/src/main/java/org/apache/nifi/metrics/jvm/JmxJvmMetrics.java
@@ -89,7 +89,7 @@ public class JmxJvmMetrics implements JvmMetrics {
}
public Set<String> getMetricNames(String metricNamePrefix) {
- if (metricNamePrefix == null || metricNamePrefix.length() == 0) {
+ if (metricNamePrefix == null || metricNamePrefix.isEmpty()) {
throw new IllegalArgumentException("A metric name prefix must be
supplied");
}
final String normalizedMetricNamePrefix =
metricNamePrefix.endsWith(".") ? metricNamePrefix : metricNamePrefix + '.';
diff --git
a/nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
b/nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
index 799d72006f8..3abce09a6c7 100644
---
a/nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
+++
b/nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
@@ -221,7 +221,7 @@ public interface SiteToSiteClient extends Closeable {
*/
public Builder url(final String url) {
final Set<String> urls = new LinkedHashSet<>();
- if (url != null && url.length() > 0) {
+ if (url != null && !url.isEmpty()) {
urls.add(url);
}
this.urls = urls;
diff --git
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/FragmentAttributes.java
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/FragmentAttributes.java
index 6f055da37bb..5beeb286a88 100644
---
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/FragmentAttributes.java
+++
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/FragmentAttributes.java
@@ -63,7 +63,7 @@ public enum FragmentAttributes implements
FlowFileAttributeKey {
public static FlowFile copyAttributesToOriginal(final ProcessSession
processSession, final FlowFile originalFlowFile,
final String fragmentId,
final int fragmentCount) {
final Map<String, String> attributesToOriginal = new HashMap<>();
- if (fragmentId != null && fragmentId.length() > 0) {
+ if (fragmentId != null && !fragmentId.isEmpty()) {
attributesToOriginal.put(FRAGMENT_ID.key(), fragmentId);
}
attributesToOriginal.put(FRAGMENT_COUNT.key(),
String.valueOf(fragmentCount));
diff --git
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/StringSelector.java
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/StringSelector.java
index f92f4ec59c0..56f7b6a7710 100644
---
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/StringSelector.java
+++
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/StringSelector.java
@@ -58,7 +58,7 @@ public interface StringSelector {
@Override
public StringSelector or(String... strings) {
for (String string : strings) {
- if (string != null && string.length() > 0) {
+ if (string != null && !string.isEmpty()) {
return new StringSelector() {
@Override
public StringSelector or(String... string) {
diff --git
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/text/RegexDateTimeMatcher.java
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/text/RegexDateTimeMatcher.java
index 04b93a14468..76c419a5ec2 100644
---
a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/text/RegexDateTimeMatcher.java
+++
b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/text/RegexDateTimeMatcher.java
@@ -260,11 +260,11 @@ public class RegexDateTimeMatcher implements
DateTimeMatcher {
return formatString.length();
} finally {
- if (textBuilder.length() == 0) {
+ if (textBuilder.isEmpty()) {
patterns.add("'");
} else {
final String text = textBuilder.toString();
- if (text.length() > 0) {
+ if (!text.isEmpty()) {
patterns.add(Pattern.quote(textBuilder.toString()));
}
}
diff --git
a/nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketRepositoryClient.java
b/nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketRepositoryClient.java
index 361826870e3..a31cdeb6c33 100644
---
a/nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketRepositoryClient.java
+++
b/nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketRepositoryClient.java
@@ -1085,7 +1085,7 @@ public class BitbucketRepositoryClient implements
GitRepositoryClient {
}
final JsonNode errorsNode = jsonResponse.get(FIELD_ERRORS);
- if (errorsNode != null && errorsNode.isArray() && errorsNode.size() >
0) {
+ if (errorsNode != null && errorsNode.isArray() &&
!errorsNode.isEmpty()) {
final JsonNode firstError = errorsNode.get(0);
return
firstError.path(FIELD_MESSAGE_TEXT).asText(firstError.toString());
}
diff --git
a/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-registry-clients/src/main/java/org/apache/nifi/azure/devops/AzureDevOpsRepositoryClient.java
b/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-registry-clients/src/main/java/org/apache/nifi/azure/devops/AzureDevOpsRepositoryClient.java
index 81464064390..2d2c79d4f5e 100644
---
a/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-registry-clients/src/main/java/org/apache/nifi/azure/devops/AzureDevOpsRepositoryClient.java
+++
b/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-registry-clients/src/main/java/org/apache/nifi/azure/devops/AzureDevOpsRepositoryClient.java
@@ -202,7 +202,7 @@ public class AzureDevOpsRepositoryClient implements
GitRepositoryClient {
final JsonNode values = response.get(JSON_FIELD_VALUE);
return values != null
&& values.isArray()
- && values.size() > 0
+ && !values.isEmpty()
&& values.get(0).asBoolean();
}
@@ -347,7 +347,7 @@ public class AzureDevOpsRepositoryClient implements
GitRepositoryClient {
}
final JsonNode values = response.get(JSON_FIELD_VALUE);
- if (values != null && values.size() > 0) {
+ if (values != null && !values.isEmpty()) {
return
Optional.ofNullable(values.get(0).get(JSON_FIELD_COMMIT_ID)).map(JsonNode::asText);
} else {
logger.debug("Unable to get content SHA for [{}] from branch [{}]
because no commits were found", resolvedPath, branch);
diff --git
a/nifi-extension-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
b/nifi-extension-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
index 269dfb956eb..336870eb004 100644
---
a/nifi-extension-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
+++
b/nifi-extension-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
@@ -1338,7 +1338,7 @@ public class CaptureChangeMySQL extends
AbstractSessionFactoryProcessor {
* @throws InitializationException if there is a problem obtaining the
ClassLoader
*/
protected void registerDriver(String locationString, String drvName)
throws InitializationException {
- if (locationString != null && locationString.length() > 0) {
+ if (locationString != null && !locationString.isEmpty()) {
try {
final Class<?> clazz = Class.forName(drvName);
final Driver driver = (Driver)
clazz.getDeclaredConstructor().newInstance();
diff --git
a/nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java
b/nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java
index 7d34996a296..81c0378f07f 100644
---
a/nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java
+++
b/nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java
@@ -1365,7 +1365,7 @@ public class PutElasticsearchJson extends
AbstractPutElasticsearch {
}
current.append(c); // lone backslash, kept literal
} else if (c == '/') {
- if (current.length() > 0) {
+ if (!current.isEmpty()) {
segments.add(current.toString());
current.setLength(0);
}
@@ -1373,7 +1373,7 @@ public class PutElasticsearchJson extends
AbstractPutElasticsearch {
current.append(c);
}
}
- if (current.length() > 0) {
+ if (!current.isEmpty()) {
segments.add(current.toString());
}
return segments.toArray(new String[0]);
diff --git
a/nifi-extension-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
b/nifi-extension-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
index ba116e8e012..b9c4866423a 100644
---
a/nifi-extension-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
+++
b/nifi-extension-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
@@ -187,7 +187,7 @@ public abstract class AbstractHadoopProcessor extends
AbstractProcessor implemen
void add(final String value) {
if (value != null) {
- if (sb.length() > 0) {
+ if (!sb.isEmpty()) {
sb.append(SEPARATOR);
}
sb.append(value);
@@ -195,7 +195,7 @@ public abstract class AbstractHadoopProcessor extends
AbstractProcessor implemen
}
String build() {
- return sb.length() > 0 ? sb.toString() : null;
+ return !sb.isEmpty() ? sb.toString() : null;
}
}
diff --git
a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonSchemaInference.java
b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonSchemaInference.java
index 5fc0e8b8b2e..5cb63d59e69 100644
---
a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonSchemaInference.java
+++
b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonSchemaInference.java
@@ -97,7 +97,7 @@ public class JsonSchemaInference extends
HierarchicalSchemaInference<JsonNode> {
@Override
protected boolean isEmptyArray(final JsonNode value) {
- return value.isArray() && value.size() == 0;
+ return value.isArray() && value.isEmpty();
}
@Override
diff --git
a/nifi-extension-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/util/Throwables.java
b/nifi-extension-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/util/Throwables.java
index de5841b8555..4a09f139bc3 100644
---
a/nifi-extension-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/util/Throwables.java
+++
b/nifi-extension-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/util/Throwables.java
@@ -117,7 +117,7 @@ public class Throwables {
}
msg = msg.trim();
//append dot at the end if no others
- if (msg.length() > 0 && ".!:,;?".indexOf(msg.substring(msg.length() -
1)) == -1) {
+ if (!msg.isEmpty() && ".!:,;?".indexOf(msg.substring(msg.length() -
1)) == -1) {
msg += "."; // NOPMD
}
diff --git
a/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
b/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
index d1bbd998758..665deceb3c3 100644
---
a/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
+++
b/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
@@ -535,7 +535,7 @@ public class GetHDFS extends AbstractHadoopProcessor {
} else {
// figure out portion of path that does not include the
provided root dir.
String relativePath = getPathDifference(dir, path);
- if (relativePath.length() == 0) {
+ if (relativePath.isEmpty()) {
pathToCompare = path.getName();
} else {
pathToCompare = relativePath + Path.SEPARATOR +
path.getName();
diff --git
a/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
b/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
index 6d617e5c883..a6a7fffe53b 100644
---
a/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
+++
b/nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
@@ -545,7 +545,7 @@ public class MoveHDFS extends AbstractHadoopProcessor {
}
final String pathToCompare;
String relativePath = getPathDifference(dir, path);
- if (relativePath.length() == 0) {
+ if (relativePath.isEmpty()) {
pathToCompare = path.getName();
} else {
pathToCompare = relativePath + Path.SEPARATOR +
path.getName();
diff --git
a/nifi-extension-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
b/nifi-extension-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
index afa2cc5fbd4..d3904189fe2 100644
---
a/nifi-extension-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
+++
b/nifi-extension-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
@@ -146,7 +146,7 @@ public class ExtractMediaMetadata extends AbstractProcessor
{
@OnScheduled
public void onScheduled(ProcessContext context) {
String metadataKeyFilterInput =
context.getProperty(METADATA_KEY_FILTER).getValue();
- if (metadataKeyFilterInput != null && metadataKeyFilterInput.length()
> 0) {
+ if (metadataKeyFilterInput != null &&
!metadataKeyFilterInput.isEmpty()) {
metadataKeyFilterRef.set(Pattern.compile(metadataKeyFilterInput));
} else {
metadataKeyFilterRef.set(null);
diff --git
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokReader.java
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokReader.java
index 2d5e3700d9b..a6ae8640f5e 100644
---
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokReader.java
+++
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokReader.java
@@ -233,7 +233,7 @@ public class GrokReader extends SchemaRegistryService
implements RecordReaderFac
private static void populateSchemaFieldNames(final Grok grok, String
grokExpression, final Collection<RecordField> fields) {
final Set<String> namedGroups =
GrokUtils.getNameGroups(GrokUtils.GROK_PATTERN.pattern());
- while (grokExpression.length() > 0) {
+ while (!grokExpression.isEmpty()) {
final Matcher matcher =
GrokUtils.GROK_PATTERN.matcher(grokExpression);
if (matcher.find()) {
final Map<String, String> extractedGroups =
GrokUtils.namedGroups(matcher, namedGroups);
diff --git
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokRecordReader.java
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokRecordReader.java
index 76958a5359e..2be64f4a0d5 100644
---
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokRecordReader.java
+++
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok/GrokRecordReader.java
@@ -175,7 +175,7 @@ public class GrokRecordReader implements RecordReader {
// If there is any trailing text, determine the last column from
the grok schema
// and then append the trailing text to it.
- if (noMatchStrategy.equals(NoMatchStrategy.APPEND) &&
trailingText.length() > 0) {
+ if (noMatchStrategy.equals(NoMatchStrategy.APPEND) &&
!trailingText.isEmpty()) {
String lastPopulatedFieldName = null;
final List<RecordField> schemaFields =
schemaFromGrok.getFields();
for (int i = schemaFields.size() - 1; i >= 0; i--) {
diff --git
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordReader.java
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordReader.java
index 22ec7e333e4..689f41d00c7 100644
---
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordReader.java
+++
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordReader.java
@@ -444,7 +444,7 @@ public class XMLRecordReader implements RecordReader {
}
}
- if (content.length() > 0) {
+ if (!content.isEmpty()) {
if (contentFieldName != null) {
final Optional<RecordField> field =
schema.getField(contentFieldName);
if (field.isPresent()) {
diff --git
a/nifi-extension-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/src/main/java/org/apache/nifi/processors/zendesk/GetZendesk.java
b/nifi-extension-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/src/main/java/org/apache/nifi/processors/zendesk/GetZendesk.java
index 9c42b1e551f..69a4fa06139 100644
---
a/nifi-extension-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/src/main/java/org/apache/nifi/processors/zendesk/GetZendesk.java
+++
b/nifi-extension-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/src/main/java/org/apache/nifi/processors/zendesk/GetZendesk.java
@@ -247,7 +247,7 @@ public class GetZendesk extends AbstractZendesk {
private int extractZendeskResourceData(JsonParser parser, JsonGenerator
generator) throws IOException {
ArrayNode zendeskItems = OBJECT_MAPPER.readTree(parser);
- if (zendeskItems.size() > 0) {
+ if (!zendeskItems.isEmpty()) {
generator.writeStartArray();
for (JsonNode zendeskItem : zendeskItems) {
generator.writeTree(zendeskItem);
diff --git
a/nifi-framework-bundle/nifi-framework-extensions/nifi-single-user-iaa-providers-bundle/nifi-single-user-iaa-providers/src/main/java/org/apache/nifi/authentication/single/user/SingleUserLoginIdentityProvider.java
b/nifi-framework-bundle/nifi-framework-extensions/nifi-single-user-iaa-providers-bundle/nifi-single-user-iaa-providers/src/main/java/org/apache/nifi/authentication/single/user/SingleUserLoginIdentityProvider.java
index 1ef3bee7293..3464aed3222 100644
---
a/nifi-framework-bundle/nifi-framework-extensions/nifi-single-user-iaa-providers-bundle/nifi-single-user-iaa-providers/src/main/java/org/apache/nifi/authentication/single/user/SingleUserLoginIdentityProvider.java
+++
b/nifi-framework-bundle/nifi-framework-extensions/nifi-single-user-iaa-providers-bundle/nifi-single-user-iaa-providers/src/main/java/org/apache/nifi/authentication/single/user/SingleUserLoginIdentityProvider.java
@@ -113,7 +113,7 @@ public class SingleUserLoginIdentityProvider implements
LoginIdentityProvider {
public void onConfigured(final LoginIdentityProviderConfigurationContext
configurationContext) throws ProviderCreationException {
LOGGER.debug("Configuring Provider");
final String password =
configurationContext.getProperty(PASSWORD_PROPERTY);
- if (password == null || password.length() == 0) {
+ if (password == null || password.isEmpty()) {
try {
configuredCredentials = generateLoginCredentials();
LOGGER.info("Updating Login Identity Providers Configuration
[{}]", loginIdentityProviderConfigurationFile);
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupDTO.java
b/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupDTO.java
index 518d7a7d670..4d3ff724525 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupDTO.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupDTO.java
@@ -85,10 +85,10 @@ public class RemoteProcessGroupDTO extends ComponentDTO {
" If neither target uri nor uris are set, then returns
null."
)
public String getTargetUri() {
- if (targetUri == null || targetUri.length() == 0) {
+ if (targetUri == null || targetUri.isEmpty()) {
synchronized (this) {
- if (targetUri == null || targetUri.length() == 0) {
- if (targetUris != null && targetUris.length() > 0) {
+ if (targetUri == null || targetUri.isEmpty()) {
+ if (targetUris != null && !targetUris.isEmpty()) {
if (targetUris.indexOf(',') > -1) {
targetUri = targetUris.substring(0,
targetUris.indexOf(','));
} else {
@@ -117,9 +117,9 @@ public class RemoteProcessGroupDTO extends ComponentDTO {
" If neither target uris nor uris are set, then returns
null."
)
public String getTargetUris() {
- if (targetUris == null || targetUris.length() == 0) {
+ if (targetUris == null || targetUris.isEmpty()) {
synchronized (this) {
- if (targetUris == null || targetUris.length() == 0) {
+ if (targetUris == null || targetUris.isEmpty()) {
targetUris = targetUri;
}
}
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
b/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
index 1070d897667..b1db067a05d 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
@@ -1905,7 +1905,7 @@ public class StandardProcessSession implements
ProcessSession, ProvenanceEventEn
}
// don't add processing time if we did nothing, because we don't log
the summary anyway
- if (sb.length() > 0) {
+ if (!sb.isEmpty()) {
final long processingNanos = checkpoint.processingTime;
sb.append(", Processing Time = ");
formatNanos(processingNanos, sb);
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
b/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
index 1c7ca5246fa..6fc35a7a9fb 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
@@ -192,7 +192,7 @@ public class NiFiPropertiesLoader {
private static boolean isKeyGenerationRequired(final NiFiProperties
properties) {
final String configuredSensitivePropertiesKey =
properties.getProperty(NiFiProperties.SENSITIVE_PROPS_KEY);
- return (configuredSensitivePropertiesKey == null ||
configuredSensitivePropertiesKey.length() == 0);
+ return (configuredSensitivePropertiesKey == null ||
configuredSensitivePropertiesKey.isEmpty());
}
private static class DuplicateDetectingProperties extends Properties {
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java
b/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java
index 4c6ed134d6e..a1e28f4127a 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java
@@ -180,12 +180,12 @@ public class StandardRemoteGroupPort extends
RemoteGroupPort {
}
final String batchSize = getBatchSize();
- if (batchSize != null && batchSize.length() > 0) {
+ if (batchSize != null && !batchSize.isEmpty()) {
clientBuilder.requestBatchSize(DataUnit.parseDataSize(batchSize.trim(),
DataUnit.B).intValue());
}
final String batchDuration = getBatchDuration();
- if (batchDuration != null && batchDuration.length() > 0) {
+ if (batchDuration != null && !batchDuration.isEmpty()) {
clientBuilder.requestBatchDuration(FormatUtils.getTimeDuration(batchDuration.trim(),
TimeUnit.MILLISECONDS), TimeUnit.MILLISECONDS);
}
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardRemoteProcessGroupDAO.java
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardRemoteProcessGroupDAO.java
index 4c8bfae9601..9531e2d1d56 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardRemoteProcessGroupDAO.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardRemoteProcessGroupDAO.java
@@ -120,7 +120,7 @@ public class StandardRemoteProcessGroupDAO extends
ComponentDAO implements Remot
}
final String targetUris = remoteProcessGroupDTO.getTargetUris();
- if (targetUris == null || targetUris.length() == 0) {
+ if (targetUris == null || targetUris.isEmpty()) {
throw new IllegalArgumentException("Cannot add a Remote Process
Group without specifying the Target URI(s)");
}
@@ -271,7 +271,7 @@ public class StandardRemoteProcessGroupDAO extends
ComponentDAO implements Remot
}
final String batchSize = batchSettingsDTO.getSize();
- if (isNotNull(batchSize) && batchSize.length() > 0
+ if (isNotNull(batchSize) && !batchSize.isEmpty()
&&
!DataUnit.DATA_SIZE_PATTERN.matcher(batchSize.trim().toUpperCase()).matches()) {
validationErrors.add(String.format("Batch size for port '%s'
must be of format <Data Size> <Data Unit>" +
" where <Data Size> is a non-negative integer and
<Data Unit> is a supported Data"
@@ -279,7 +279,7 @@ public class StandardRemoteProcessGroupDAO extends
ComponentDAO implements Remot
}
final String batchDuration = batchSettingsDTO.getDuration();
- if (isNotNull(batchDuration) && batchDuration.length() > 0
+ if (isNotNull(batchDuration) && !batchDuration.isEmpty()
&&
!FormatUtils.TIME_DURATION_PATTERN.matcher(batchDuration.trim().toLowerCase()).matches())
{
validationErrors.add(String.format("Batch duration for port
'%s' must be of format <duration> <TimeUnit>" +
" where <duration> is a non-negative integer and
TimeUnit is a supported Time Unit, such "
diff --git
a/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java
b/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java
index 8cd5e3691ca..dcdae4e2280 100644
--- a/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java
+++ b/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java
@@ -1177,7 +1177,7 @@ public class MockProcessSession implements ProcessSession
{
final String sourceUuid =
source.getAttribute(CoreAttributes.UUID.key());
if (sourceUuid != null && !sourceUuid.isBlank()) {
uuidsCaptured++;
- if (parentUuidBuilder.length() > 0) {
+ if (!parentUuidBuilder.isEmpty()) {
parentUuidBuilder.append(",");
}
parentUuidBuilder.append(sourceUuid);
diff --git
a/nifi-registry/nifi-registry-core/nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/WhitelistFilteringEventHookProvider.java
b/nifi-registry/nifi-registry-core/nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/WhitelistFilteringEventHookProvider.java
index 829f3d82d92..2e8adb84e53 100644
---
a/nifi-registry/nifi-registry-core/nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/WhitelistFilteringEventHookProvider.java
+++
b/nifi-registry/nifi-registry-core/nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/WhitelistFilteringEventHookProvider.java
@@ -38,7 +38,7 @@ public abstract class WhitelistFilteringEventHookProvider
whiteListEvents = new HashSet<>();
for (Map.Entry<String, String> entry :
configurationContext.getProperties().entrySet()) {
Matcher matcher = EVENT_WHITELIST_PATTERN.matcher(entry.getKey());
- if (matcher.matches() && (entry.getValue() != null &&
entry.getValue().length() > 0)) {
+ if (matcher.matches() && (entry.getValue() != null &&
!entry.getValue().isEmpty())) {
whiteListEvents.add(EventType.valueOf(entry.getValue()));
}
diff --git
a/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/ExternalControllerServiceVersioningIT.java
b/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/ExternalControllerServiceVersioningIT.java
index b96ae82bb27..3fabe2023da 100644
---
a/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/ExternalControllerServiceVersioningIT.java
+++
b/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/ExternalControllerServiceVersioningIT.java
@@ -351,7 +351,7 @@ public class ExternalControllerServiceVersioningIT extends
NiFiSystemIT {
}
}
}
- return sb.length() == 0 ? "<none>" : sb.toString();
+ return sb.isEmpty() ? "<none>" : sb.toString();
}
/**
diff --git
a/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/RebaseVersionIT.java
b/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/RebaseVersionIT.java
index ae57b15dbe6..2bcad860ccc 100644
---
a/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/RebaseVersionIT.java
+++
b/nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/registry/RebaseVersionIT.java
@@ -583,7 +583,7 @@ public class RebaseVersionIT extends NiFiSystemIT {
}
sb.append(service.getId()).append("=").append(service.getComponent().getType());
}
- return sb.length() == 0 ? "none" : sb.toString();
+ return sb.isEmpty() ? "none" : sb.toString();
}
private String describeComponentDifferences(final
Collection<ComponentDifferenceDTO> componentDifferences) {
@@ -609,7 +609,7 @@ public class RebaseVersionIT extends NiFiSystemIT {
}
}
}
- return sb.length() == 0 ? "none" : sb.toString();
+ return sb.isEmpty() ? "none" : sb.toString();
}
private void executeRebaseWithFingerprint(final ProcessGroupEntity group,
final String targetVersion, final String fingerprint)
