[ https://issues.apache.org/jira/browse/NIFI-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527110#comment-14527110 ]
Joseph Witt commented on NIFI-586: ---------------------------------- I am thinking that the <> (diamond operator) is strongly preferred. I think this is a findbugs detector we should turn off. Thanks Joe > Add types to most collections to improve type safety > ---------------------------------------------------- > > Key: NIFI-586 > URL: https://issues.apache.org/jira/browse/NIFI-586 > Project: Apache NiFi > Issue Type: Task > Affects Versions: 0.0.2 > Reporter: Mark Latimer > Priority: Minor > Attachments: NIFI-586_0001-Added-types-to-most-collections.patch > > > The attached patch adds type information in many if not most places where > collections are created. > For example > final Set<Relationship> relationships = new HashSet<>(((Processor) > component).getRelationships()); > becomes > final Set<Relationship> relationships = new > HashSet<Relationship>(((Processor) component).getRelationships()); > While likely unnecessary in many places it should help catch some issues > earlier in the future. > The patch does touch many files (over 400). -- This message was sent by Atlassian JIRA (v6.3.4#6332)