[ 
https://issues.apache.org/jira/browse/NIFI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604340#comment-14604340
 ] 

Matt Gilman commented on NIFI-735:
----------------------------------

That's a great point. Ultimately all I wanted to do was make sure that the 
processor's be given the opportunity to clean up any resources/state they may 
have initialized upon construction or during the init() call. If we think that 
OnShutdown is sufficient than that's fine by me. 

> DocGenerator should on @OnUnscheduled and @OnStopped after its done 
> generating the docs
> ---------------------------------------------------------------------------------------
>
>                 Key: NIFI-735
>                 URL: https://issues.apache.org/jira/browse/NIFI-735
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.1.0
>            Reporter: Dan Bress
>            Assignee: Dan Bress
>             Fix For: 0.2.0
>
>         Attachments: 
> 0001-NIFI-735-DocGenerator-should-on-OnUnscheduled-and-On.patch
>
>
> Per [~mcgilman]
> +0 for triggering OnRemoved and OnShutdown after initialization and before 
> being done with instance
> +0 for triggering OnRemoved and OnShutdown and not their deprecated 
> counterparts
> Change code to call annotations *after* the documentation has been generated 
> for that component.  Also invoke both the new annotations and the deprecated 
> annotations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to