[incubator-nlpcraft] branch NLPCRAFT-468 updated: WIP.

[sergeykamov]

This is an automated email from the ASF dual-hosted git repository.

sergeykamov pushed a commit to branch NLPCRAFT-468
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git


The following commit(s) were added to refs/heads/NLPCRAFT-468 by this push:
     new 8981309  WIP.
8981309 is described below

commit 898130927519c96231dc5f6e55bf7f12da7e7ab2
Author: Sergey Kamov <skhdlem...@gmail.com>
AuthorDate: Mon Oct 11 15:04:59 2021 +0300

    WIP.
---
 .../src/main/scala/org/apache/nlpcraft/model/NCModel.java  |  4 +++-
 .../org/apache/nlpcraft/model/builders/NCModelBuilder.java | 14 ++++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModel.java 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModel.java
index f48e9d8..6caa66a 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModel.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModel.java
@@ -22,7 +22,9 @@ package org.apache.nlpcraft.model;
  */
 public interface NCModel extends NCModelView {
     NCModelBehaviour getModelBehaviour();
-    // TDOO: do we need it?
+
+    // TDOO: do we need these methods?
+    // Maybe model should be already prepared (`start` omitted) + autoclosable 
?
     void start();
     void stop();
 }
diff --git 
a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/builders/NCModelBuilder.java
 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/builders/NCModelBuilder.java
index 73b7095..4d0b3ec 100644
--- 
a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/builders/NCModelBuilder.java
+++ 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/builders/NCModelBuilder.java
@@ -86,7 +86,7 @@ public class NCModelBuilder {
         return null;
     }
 
-    // 2. Words.
+    // 2. Words - for built stop/swear EN detection. (Suspicious vai 
dictioanry)
     public NCModelBuilder withAdditionalStopWords(Set<String> 
additionalStopWords) {
         return null;
     }
@@ -97,14 +97,17 @@ public class NCModelBuilder {
         return null;
     }
 
-    // TODO: 3 custom words - discuss it.
-    public NCModelBuilder withStopWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> filter) {
+    // TODO: Alternative - 3 custom words free implementation support - 
discuss it.
+    // We can provie all logic via these components for DE etc.
+    // Function<List<NCNlpWord>, List<NCNlpWord>> filter
+    // input - all sentence's words, output - detected stop/swear words. Empty 
result - not found.
+    public NCModelBuilder withStopWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> finder) {
         return null;
     }
-    public NCModelBuilder withSwearWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> filter) {
+    public NCModelBuilder withSwearWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> finder) {
         return null;
     }
-    public NCModelBuilder withSuspiciousWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> filter) {
+    public NCModelBuilder withSuspiciousWordsFilter(Function<List<NCNlpWord>, 
List<NCNlpWord>> finder) {
         return null;
     }
 
@@ -145,7 +148,6 @@ public class NCModelBuilder {
         return null;
     }
 
-
     // 6. Behaviour
     public NCModelBuilder withModelBehaviour(NCModelBehaviour behaviour) {
         return null;