This is an automated email from the ASF dual-hosted git repository.
sergeykamov pushed a commit to branch NLPCRAFT-468
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git
The following commit(s) were added to refs/heads/NLPCRAFT-468 by this push:
new 634c4a2 WIP.
634c4a2 is described below
commit 634c4a2bd26194d9596b8e7e676072fac9516804
Author: Sergey Kamov <[email protected]>
AuthorDate: Tue Oct 12 22:23:40 2021 +0300
WIP.
---
.../test/java/org/apache/nlpcraft/spring/NlpCraftConfig.java | 2 +-
.../main/scala/org/apache/nlpcraft/NCNlpcraftBuilder.java | 12 +-----------
.../scala/org/apache/nlpcraft/model/nlp/NCNlpDetector.java | 6 +++---
.../scala/org/apache/nlpcraft/model/nlp/NCNlpNerParser.java | 7 ++++---
.../scala/org/apache/nlpcraft/model/nlp/NCNlpTokenizer.java | 3 ++-
nlpcraft/src/test/java/org/apache/nlpcraft/NCSpec.java | 2 +-
6 files changed, 12 insertions(+), 20 deletions(-)
diff --git
a/nlpcraft-spring/src/test/java/org/apache/nlpcraft/spring/NlpCraftConfig.java
b/nlpcraft-spring/src/test/java/org/apache/nlpcraft/spring/NlpCraftConfig.java
index 935f21e..f2469e6 100644
---
a/nlpcraft-spring/src/test/java/org/apache/nlpcraft/spring/NlpCraftConfig.java
+++
b/nlpcraft-spring/src/test/java/org/apache/nlpcraft/spring/NlpCraftConfig.java
@@ -52,6 +52,6 @@ public class NlpCraftConfig {
@Bean
public NCNlpcraft getNlpCraft(NCModel mdl) {
- return new NCNlpcraftBuilder().withModel(mdl).getNlpcraft();
+ return new NCNlpcraftBuilder().getNlpcraft(mdl);
}
}
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCNlpcraftBuilder.java
b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCNlpcraftBuilder.java
index e38eb64..ae171be 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCNlpcraftBuilder.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCNlpcraftBuilder.java
@@ -25,17 +25,7 @@ import java.util.List;
import java.util.Map;
public class NCNlpcraftBuilder {
- // There we can validate user prepared model.
- public NCNlpcraftBuilder withModel(NCModel mdl) {
- return this;
- }
-
- // TODO: add deserialization component.
- //public NCNlpcraftBuilder withUrl(String url) {
- // return null;
- //}
-
- public NCNlpcraft getNlpcraft() {
+ public NCNlpcraft getNlpcraft(NCModel mdl) {
return new NCNlpcraft() {
@Override
public String ask(String txt, Map<String, Object> data, boolean
enableLog, String userId) {
diff --git
a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpDetector.java
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpDetector.java
index 04c82ab..222aab1 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpDetector.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpDetector.java
@@ -24,13 +24,13 @@ import java.util.List;
/**
* For detection stop, swear and suspicios words in sentence.
*
- * Provided default implementation for stop and swear USA words.
+ * Provided default implementations for stop and swear USA words.
* -
org.apache.nlpcraft.model.components.detectors.NCDefaultStopWordsDetector,
* -
org.apache.nlpcraft.model.components.detectors.NCDefaultSwearWordsDetector
*
- * Additionally and excluded stop words can be impemented by overriding
default solution.
+ * If you want to extend logic by additionally and excluded stop words - it
can be impemented by overriding default solution.
*
- * Custom and language related solutions should be implemented and defined in
model configuration.
+ * Custom and language related solutions should be implemented and set in
model configuration.
*
*/
public interface NCNlpDetector {
diff --git
a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpNerParser.java
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpNerParser.java
index 37c8ab9..811721d 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpNerParser.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpNerParser.java
@@ -25,9 +25,10 @@ import java.util.List;
/**
* TODO:
- * OnenNlp implementation - provided (DATE etc)
- * Stanford implementation - separated module.
- * User implementations can be provided too.
+ * - Synonyms based implementation - provided.
+ * - OnenNlp implementation - provided (DATE etc)
+ * - Stanford implementation - separated module.
+ * - user custom implementations can be provided too.
*
* Order of configured NCNlpNerTokensParser elements is important.
* Only one parsers iteration called.
diff --git
a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpTokenizer.java
b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpTokenizer.java
index d8b033b..96e2d29 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpTokenizer.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/nlp/NCNlpTokenizer.java
@@ -22,7 +22,8 @@ import org.apache.nlpcraft.model.NCRequest;
import java.util.List;
/**
- * Test tokenizer.
+ * Text tokenizer.
+ *
* Default implementation provided and based on OpenNlp solution.
* org.apache.nlpcraft.model.components.tokenizer.NCOpenNlpTokenizer
*
diff --git a/nlpcraft/src/test/java/org/apache/nlpcraft/NCSpec.java
b/nlpcraft/src/test/java/org/apache/nlpcraft/NCSpec.java
index 48bfaea..11a2b0b 100644
--- a/nlpcraft/src/test/java/org/apache/nlpcraft/NCSpec.java
+++ b/nlpcraft/src/test/java/org/apache/nlpcraft/NCSpec.java
@@ -119,7 +119,7 @@ public class NCSpec {
mdl.start();
- NCNlpcraft nlp = new NCNlpcraftBuilder().withModel(mdl).getNlpcraft();
+ NCNlpcraft nlp = new NCNlpcraftBuilder().getNlpcraft(mdl);
String reqId = nlp.ask("weather today");
